Bug fix: get rid of str_formatter

-- it can only be used from the main domain.

CHANGELOG.md

@@ -1,8 +1,9 @@
-## [2.0.1] -- current
+## [2.0.1] -- 2024-09-08
 
 ### Fixed
 
 - Write the whole incomplete log tree on the error "lexical scope of close_log not matching its dynamic scope" by snapshotting, so the entries from the error message can be looked up.
+- Don't use `str_formatter`, it's only meant to be used from the main domain. (It affected timestamps, and `_pp` entry points for the flushing backend.)
 
 ## [2.0.0] -- 2024-08-26
 

minidebug_runtime.ml

@@ -8,13 +8,14 @@ let pp_timestamp ppf () =
   Ptime.(pp_human ~frac_s:6 ?tz_offset_s ()) ppf (Ptime_clock.now ())
 
 let timestamp_to_string () =
-  let _ = CFormat.flush_str_formatter () in
+  let buf = Buffer.create 512 in
+  let formatter = CFormat.formatter_of_buffer buf in
   let tz_offset_s = Ptime_clock.current_tz_offset_s () in
-  Ptime.(pp_human ~frac_s:6 ?tz_offset_s ()) CFormat.str_formatter (Ptime_clock.now ());
-  CFormat.flush_str_formatter ()
+  Ptime.(pp_human ~frac_s:6 ?tz_offset_s ()) formatter (Ptime_clock.now ());
+  CFormat.pp_print_flush formatter ();
+  Buffer.contents buf
 
 let pp_elapsed ppf () =
-  let _ = CFormat.flush_str_formatter () in
   let e = time_elapsed () in
   let ns =
     match Int64.unsigned_to_int @@ Mtime.Span.to_uint64_ns e with
@@ -391,9 +392,11 @@ module Flushing (Log_to : Shared_config) : Debug_runtime = struct
     if check_log_level log_level then (
       let orphaned = bump_stack_entry entry_id in
       let descr = match descr with None -> "" | Some d -> d ^ " = " in
-      let _ = CFormat.flush_str_formatter () in
-      pp CFormat.str_formatter v;
-      let v_str = CFormat.flush_str_formatter () in
+      let buf = Buffer.create 512 in
+      let formatter = CFormat.formatter_of_buffer buf in
+      pp formatter v;
+      CFormat.pp_print_flush formatter ();
+      let v_str = Buffer.contents buf in
       Printf.fprintf !debug_ch "%s%s%s%s\n%!" (indent ()) orphaned descr v_str)
 
   let log_value_show ?descr ~entry_id ~log_level ~is_result:_ v =