MakeFactory::getPath() wasn't normalized

lunarstorm · Mar 11, 2024 · 98da7da · 98da7da
1 parent 60b0e0d
commit 98da7da
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Commands/MakeFactory.php b/src/Commands/MakeFactory.php
@@ -3,6 +3,7 @@
 namespace Lunarstorm\LaravelDDD\Commands;
 
 use Lunarstorm\LaravelDDD\Support\Domain;
+use Lunarstorm\LaravelDDD\Support\Path;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputOption;
 
@@ -74,7 +75,7 @@ protected function getPath($name)
             ->append('.php')
             ->toString();
 
-        return base_path('database/factories/'.$name);
+        return Path::normalize(base_path('database/factories/'.$name));
     }
 
     protected function getFactoryName()

diff --git a/tests/Generator/MakeFactoryTest.php b/tests/Generator/MakeFactoryTest.php
@@ -4,6 +4,7 @@
 use Illuminate\Support\Facades\Config;
 use Illuminate\Support\Str;
 use Lunarstorm\LaravelDDD\Support\Domain;
+use Lunarstorm\LaravelDDD\Support\Path;
 use Lunarstorm\LaravelDDD\Tests\Fixtures\Enums\Feature;
 
 it('can generate domain factories', function ($domainPath, $domainRoot, $domain, $subdomain) {
@@ -23,7 +24,7 @@
 
     $domainFactory = $domain->factory($factoryName);
 
-    $expectedFactoryPath = base_path($domainFactory->path);
+    $expectedFactoryPath = Path::normalize(base_path($domainFactory->path));
 
     if (file_exists($expectedFactoryPath)) {
         unlink($expectedFactoryPath);