Add CameraExposureOffset and Fix Disparity to Depth Computation #346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Author: Borong Yuan
These updates are mainly for SLAM applications.
Some SLAM algorithms require the input images to have exactly the same timestamp. When we use a separate Publisher for each camera, the timestamps will not be exactly the same since the exposure is controlled individually. Only those algorithms that support approx sync can be used. Modified so that multiple synced images can now be published in one BridgePublisher. One image acts as the main image, and other images are synchronized with it by comparing sequenceNum. All images are assigned the exact same timestamp as the main image. For example, we want to publish exact synced left, right and depth images. We use the depth image as the main image since it always arrives last. In the callback function of depth image, we find the frame with the same sequenceNum from left and right image queues. They will arrive no later than the depth image, so there will be no blocking.We found it easier to achieve exact sync without using BridgePublisher. So revert to the previous version.Changes
ROS distro: Noetic
List of changes:
Testing
Hardware used:
Depthai library version: v2.22.0
CI fails due to warnings generated by API changes.
Visuals from testing
Add screenshots/gifs/videos from RVIZ or other visualizers demonstrating the effect of the changes when applicable.