Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imu sync fix humble #357

Merged
merged 7 commits into from
Aug 7, 2023
Merged

Imu sync fix humble #357

merged 7 commits into from
Aug 7, 2023

Conversation

Serafadam
Copy link
Collaborator

Overview

Author: @Serafadam

Issue

Issue link (if present): #330
Issue description: Segfault occurred randomly when filling out IMU messages.
Related PRs: N/A

Changes

ROS distro: Humble
List of changes:

  • Added overloaded interpolation methods that work only with Gyro & Accel data
  • Added additional checks when converting messages
  • Updated camera socket API
  • Removed distortion from stereo messages in depthai_ros_driver

Testing

Hardware used: OAK-D-PRO
Depthai library version: 2.22.0

Visuals from testing

Add screenshots/gifs/videos from RVIZ or other visualizers demonstrating the effect of the changes when applicable.
N/A

@Serafadam Serafadam merged commit 0a977db into humble Aug 7, 2023
5 checks passed
@Serafadam Serafadam deleted the imu_sync_fix_humble branch August 7, 2023 12:46
@@ -108,17 +108,25 @@ class ImuConverter {
}

if(_syncMode == ImuSyncMethod::LINEAR_INTERPOLATE_ACCEL) {
if(accelHist.size() < 3) {
if(accelHist.size() < 3 && gyroHist.size() && rotationHist.size() && magnHist.size()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these though ?

@Serafadam Serafadam mentioned this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants