Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha scaling Noetic #439

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Alpha scaling Noetic #439

merged 6 commits into from
Oct 16, 2023

Conversation

Serafadam
Copy link
Collaborator

Overview

Author: @Serafadam

Issue

Issue link (if present): #416 (comment)
Issue description: Updating CameraInfo based on alpha scaling
Related PRs: N/A

Changes

ROS distro: Noetic
List of changes:

  • Added a method in ImageConverter to include Alpha Scaling when calculating intrinsics
  • Minor bugfix regarding maximum Video size for RGB node

Testing

Hardware used: OAK-D-PRO
Depthai library version: 2.20

Visuals from testing

Add screenshots/gifs/videos from RVIZ or other visualizers demonstrating the effect of the changes when applicable.

@Serafadam Serafadam merged commit 0b7e450 into noetic Oct 16, 2023
3 checks passed
@Serafadam Serafadam deleted the alpha_scaling_noetic branch October 16, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant