Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yolo example for stereo/no-stereo - Humble #447

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

richard-xx
Copy link
Contributor

Overview

Author: @richard-xx

Issue

Issue link (if present): N/A
Issue description: Fix yolo example runtime error:Streams have duplicate name 'detections'
Related PRs N/A

Changes

ROS distro: Humble
List of changes:

  • Refactored the spatial_camera parameter
  • Added the source code for a YOLOv4 publisher

Testing

Hardware used: OAK-D-PRO
Depthai library version: 2.20.0

Visuals from testing

Error snapshot:

Error

…e the code

   - Removed the `spatial_camera` parameter.
   - Adjusted related settings.
   - Adjusted camera and depth camera settings.
   - Retrieved some parameters from the ROS node.
   - Updated the pipeline creation method.
Added the source code for a YOLOv4 publisher, including pipeline creation, parameter initialization, and publishing of camera frames and YOLOv4 detections.
…v4 node

Added YOLOv4 node to the build process, defined the BLOB_NAME for YOLOv4, and updated target compile definitions to include the YOLOv4 node.
… YOLOv4 Node

   - Refactored the launch file for the YOLOv4 publisher node.
   - Modified launch conditions using `IfCondition` and `UnlessCondition` to control node execution based on the `spatial_camera` parameter.
   - Updated parameters for the YOLOv4 Spatial Node, including `subpixel`, `lrCheckTresh`, and `confidence`.
   - Added a launch action for the YOLOv4 Node with appropriate parameters and launch condition.
- Removed unnecessary whitespace from the YOLOv4 publisher source code in `yolov4_publisher.cpp`.
@Serafadam Serafadam merged commit ea2f1b0 into luxonis:humble Dec 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants