Use simulation flag to decide how to load meshes. #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muritane
pushed a commit
to StoglRobotics-forks/depthai-ros
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition enables to set simulation flag to have correct paths when using Gazebo which needs absolute system paths.
And also relative package:// paths when using sensor on the hardware and accessing it from remote computer. Use-case here is that we usually execute robot description on the hardware, but want to visualize meshes on the local machine in rviz.
Unfortunatelly, I don't see other option than adding another flag to the macro. If somebody has better idea, let me know!
Note: follow also - SICKAG/sick_safteyscanners2#41