Upsample mode parameter for UpBlock #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokovninn
requested review from
kozlov721,
klemen1999,
tersekmatija and
conorsim
and removed request for
a team
Test Results 1 files 1 suites 22m 51s ⏱️ Results for commit 32824d0. ♻️ This comment has been updated with latest results. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
kozlov721
reviewed
Sep 20, 2024
luxonis_train/nodes/blocks/blocks.py
Outdated
| ConvModule(out_channels, out_channels, kernel_size=3, padding=1), | ||
| layers = [] | ||
|
|
||
| if upsample_mode == "transpose": |
There was a problem hiding this comment.
Should this be "cov_transpose"?
klemen1999
approved these changes
Sep 22, 2024
kozlov721
pushed a commit
that referenced
this pull request
Oct 9, 2024
Co-authored-by: GitHub Actions <actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
upsample_modeparameter to theUpBlock, which is used in the default segmentation head, to avoid checkerboard artifacts caused by thenn.ConvTranspose2dlayer.Now,
nn.Upsampleis the default choice in theUpBlock.