Skip to content

Commit

Permalink
feat: update bundle and catalog for renaming
Browse files Browse the repository at this point in the history
  • Loading branch information
lwpk110 committed Jul 18, 2024
1 parent 924fad5 commit 3f77df7
Show file tree
Hide file tree
Showing 12 changed files with 62 additions and 62 deletions.
6 changes: 3 additions & 3 deletions bundle/manifests/hdfs-operator.clusterserviceversion.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ metadata:
},
"spec": {
"clusterConfig": {
"zookeeperDiscoveryZNode": "sample-hdfs"
"zookeeperConfigMapName": "sample-hdfs"
},
"dataNode": {
"roleGroups": {
Expand Down Expand Up @@ -133,8 +133,8 @@ metadata:
]
capabilities: Basic Install
categories: Big Data
createdAt: "2024-07-13T10:16:44Z"
operators.operatorframework.io/builder: operator-sdk-v1.35.0
createdAt: "2024-07-18T07:36:46Z"
operators.operatorframework.io/builder: operator-sdk-v1.33.0
operators.operatorframework.io/project_layout: go.kubebuilder.io/v4
name: hdfs-operator.v0.0.1
namespace: placeholder
Expand Down
2 changes: 1 addition & 1 deletion bundle/manifests/hdfs.zncdata.dev_hdfsclusters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ spec:
for a service
type: string
type: object
zookeeperDiscoveryZNode:
zookeeperConfigMapName:
type: string
type: object
dataNode:
Expand Down
2 changes: 1 addition & 1 deletion bundle/metadata/annotations.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ annotations:
operators.operatorframework.io.bundle.package.v1: hdfs-operator
operators.operatorframework.io.bundle.channels.v1: stable
operators.operatorframework.io.bundle.channel.default.v1: stable
operators.operatorframework.io.metrics.builder: operator-sdk-v1.35.0
operators.operatorframework.io.metrics.builder: operator-sdk-v1.33.0
operators.operatorframework.io.metrics.mediatype.v1: metrics+v1
operators.operatorframework.io.metrics.project_layout: go.kubebuilder.io/v4

Expand Down
2 changes: 1 addition & 1 deletion deploy/cluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ spec:
repository: docker.stackable.tech/stackable/hadoop
tag: 3.3.4-stackable24.3.0
clusterConfig:
zookeeperDiscoveryZNode: sample-hdfs
zookeeperConfigMapName: sample-hdfs
nameNode:
roleGroups:
default:
Expand Down
10 changes: 5 additions & 5 deletions internal/controller/data/container/datanode.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (

type DataNodeContainerBuilder struct {
common.ContainerBuilder
zookeeperDiscoveryZNode string
clusterConfig *hdfsv1alpha1.ClusterConfigSpec
zookeeperConfigMapName string
clusterConfig *hdfsv1alpha1.ClusterConfigSpec
}

func NewDataNodeContainerBuilder(
Expand All @@ -23,9 +23,9 @@ func NewDataNodeContainerBuilder(
imagePullPolicy := imageSpec.PullPolicy
clusterConfig := instance.Spec.ClusterConfigSpec
return &DataNodeContainerBuilder{
ContainerBuilder: *common.NewContainerBuilder(image, imagePullPolicy, resource),
zookeeperDiscoveryZNode: clusterConfig.ZookeeperConfigMapName,
clusterConfig: clusterConfig,
ContainerBuilder: *common.NewContainerBuilder(image, imagePullPolicy, resource),
zookeeperConfigMapName: clusterConfig.ZookeeperConfigMapName,
clusterConfig: clusterConfig,
}
}

Expand Down
22 changes: 11 additions & 11 deletions internal/controller/data/container/init_container.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ import (

type WaitNameNodeContainerBuilder struct {
common.ContainerBuilder
zookeeperDiscoveryZNode string
instanceName string
groupName string
namespace string
clusterConfig *hdfsv1alpha1.ClusterConfigSpec
zookeeperConfigMapName string
instanceName string
groupName string
namespace string
clusterConfig *hdfsv1alpha1.ClusterConfigSpec
}

func NewWaitNameNodeContainerBuilder(
Expand All @@ -28,12 +28,12 @@ func NewWaitNameNodeContainerBuilder(
clusterConfigSpec := instance.Spec.ClusterConfigSpec
image := util.ImageRepository(imageSpec.Repository, imageSpec.Tag)
return &WaitNameNodeContainerBuilder{
ContainerBuilder: *common.NewContainerBuilder(image, imageSpec.PullPolicy, resource),
zookeeperDiscoveryZNode: clusterConfigSpec.ZookeeperConfigMapName,
instanceName: instance.Name,
groupName: groupName,
namespace: instance.Namespace,
clusterConfig: clusterConfigSpec,
ContainerBuilder: *common.NewContainerBuilder(image, imageSpec.PullPolicy, resource),
zookeeperConfigMapName: clusterConfigSpec.ZookeeperConfigMapName,
instanceName: instance.Name,
groupName: groupName,
namespace: instance.Namespace,
clusterConfig: clusterConfigSpec,
}
}

Expand Down
10 changes: 5 additions & 5 deletions internal/controller/journal/container.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (

type ContainerBuilder struct {
common.ContainerBuilder
zookeeperDiscoveryZNode string
clusterConfig *hdfsv1alpha1.ClusterConfigSpec
zookeeperConfigMapName string
clusterConfig *hdfsv1alpha1.ClusterConfigSpec
}

func NewJournalNodeContainerBuilder(
Expand All @@ -23,9 +23,9 @@ func NewJournalNodeContainerBuilder(
imagePullPolicy := imageSpec.PullPolicy
clusterConfig := instance.Spec.ClusterConfigSpec
return &ContainerBuilder{
ContainerBuilder: *common.NewContainerBuilder(image, imagePullPolicy, resource),
zookeeperDiscoveryZNode: clusterConfig.ZookeeperConfigMapName,
clusterConfig: clusterConfig,
ContainerBuilder: *common.NewContainerBuilder(image, imagePullPolicy, resource),
zookeeperConfigMapName: clusterConfig.ZookeeperConfigMapName,
clusterConfig: clusterConfig,
}
}

Expand Down
26 changes: 13 additions & 13 deletions internal/controller/name/container/format_namenode.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ import (
// FormatNameNodeContainerBuilder container builder
type FormatNameNodeContainerBuilder struct {
common.ContainerBuilder
zookeeperDiscoveryZNode string
nameNodeReplicates int32
statefulSetName string
instanceName string
namespace string
clusterConfig *hdfsv1alpha1.ClusterConfigSpec
zookeeperConfigMapName string
nameNodeReplicates int32
statefulSetName string
instanceName string
namespace string
clusterConfig *hdfsv1alpha1.ClusterConfigSpec
}

func NewFormatNameNodeContainerBuilder(
Expand All @@ -32,13 +32,13 @@ func NewFormatNameNodeContainerBuilder(
image := util.ImageRepository(imageSpec.Repository, imageSpec.Tag)
clusterConfig := instance.Spec.ClusterConfigSpec
return &FormatNameNodeContainerBuilder{
ContainerBuilder: *common.NewContainerBuilder(image, imageSpec.PullPolicy, resource),
zookeeperDiscoveryZNode: clusterConfig.ZookeeperConfigMapName,
nameNodeReplicates: nameNodeReplicates,
statefulSetName: statefulSetName,
instanceName: instance.Name,
namespace: instance.Namespace,
clusterConfig: clusterConfig,
ContainerBuilder: *common.NewContainerBuilder(image, imageSpec.PullPolicy, resource),
zookeeperConfigMapName: clusterConfig.ZookeeperConfigMapName,
nameNodeReplicates: nameNodeReplicates,
statefulSetName: statefulSetName,
instanceName: instance.Name,
namespace: instance.Namespace,
clusterConfig: clusterConfig,
}
}

Expand Down
16 changes: 8 additions & 8 deletions internal/controller/name/container/format_zk.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,24 +10,24 @@ import (
// FormatZookeeperContainerBuilder container builder
type FormatZookeeperContainerBuilder struct {
common.ContainerBuilder
zookeeperDiscoveryZNode string
namespace string
clusterConfig *hdfsv1alpha1.ClusterConfigSpec
zookeeperConfigMapName string
namespace string
clusterConfig *hdfsv1alpha1.ClusterConfigSpec
}

func NewFormatZookeeperContainerBuilder(
instance *hdfsv1alpha1.HdfsCluster,
resource corev1.ResourceRequirements,
zookeeperDiscoveryZNode string,
zookeeperConfigMapName string,
) *FormatZookeeperContainerBuilder {
imageSpec := instance.Spec.Image
image := util.ImageRepository(imageSpec.Repository, imageSpec.Tag)

return &FormatZookeeperContainerBuilder{
ContainerBuilder: *common.NewContainerBuilder(image, imageSpec.PullPolicy, resource),
zookeeperDiscoveryZNode: zookeeperDiscoveryZNode,
namespace: instance.Namespace,
clusterConfig: instance.Spec.ClusterConfigSpec,
ContainerBuilder: *common.NewContainerBuilder(image, imageSpec.PullPolicy, resource),
zookeeperConfigMapName: zookeeperConfigMapName,
namespace: instance.Namespace,
clusterConfig: instance.Spec.ClusterConfigSpec,
}
}

Expand Down
12 changes: 6 additions & 6 deletions internal/controller/name/container/namenode.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (

type NameNodeContainerBuilder struct {
common.ContainerBuilder
zookeeperDiscoveryZNode string
clusterConfig *hdfsv1alpha1.ClusterConfigSpec
zookeeperConfigMapName string
clusterConfig *hdfsv1alpha1.ClusterConfigSpec
}

func NewNameNodeContainerBuilder(
Expand All @@ -20,11 +20,11 @@ func NewNameNodeContainerBuilder(
imageSpec := instance.Spec.Image
image := util.ImageRepository(imageSpec.Repository, imageSpec.Tag)
imagePullPolicy := imageSpec.PullPolicy
zookeeperDiscoveryZNode := instance.Spec.ClusterConfigSpec.ZookeeperConfigMapName
zookeeperConfigMapName := instance.Spec.ClusterConfigSpec.ZookeeperConfigMapName
return &NameNodeContainerBuilder{
ContainerBuilder: *common.NewContainerBuilder(image, imagePullPolicy, resource),
zookeeperDiscoveryZNode: zookeeperDiscoveryZNode,
clusterConfig: instance.Spec.ClusterConfigSpec,
ContainerBuilder: *common.NewContainerBuilder(image, imagePullPolicy, resource),
zookeeperConfigMapName: zookeeperConfigMapName,
clusterConfig: instance.Spec.ClusterConfigSpec,
}
}

Expand Down
12 changes: 6 additions & 6 deletions internal/controller/name/container/zkfc.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (
// zkfc container builder
type ZkfcContainerBuilder struct {
common.ContainerBuilder
zookeeperDiscoveryZNode string
clusterConfig *hdfsv1alpha1.ClusterConfigSpec
zookeeperConfigMapName string
clusterConfig *hdfsv1alpha1.ClusterConfigSpec
}

func NewZkfcContainerBuilder(
Expand All @@ -22,11 +22,11 @@ func NewZkfcContainerBuilder(
image := util.ImageRepository(imageSpec.Repository, imageSpec.Tag)
imagePullPolicy := imageSpec.PullPolicy
clusterConfig := instance.Spec.ClusterConfigSpec
zookeeperDiscoveryZNode := clusterConfig.ZookeeperConfigMapName
zookeeperConfigMapName := clusterConfig.ZookeeperConfigMapName
return &ZkfcContainerBuilder{
ContainerBuilder: *common.NewContainerBuilder(image, imagePullPolicy, resource),
zookeeperDiscoveryZNode: zookeeperDiscoveryZNode,
clusterConfig: clusterConfig,
ContainerBuilder: *common.NewContainerBuilder(image, imagePullPolicy, resource),
zookeeperConfigMapName: zookeeperConfigMapName,
clusterConfig: clusterConfig,
}
}

Expand Down
4 changes: 2 additions & 2 deletions internal/controller/name/statefulset.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ func (s *StatefulSetReconciler) makeFormatZookeeperContainer() corev1.Container
formatZookeeper := container.NewFormatZookeeperContainerBuilder(
s.Instance,
*common.ConvertToResourceRequirements(s.MergedCfg.Config.Resources),
s.getZookeeperDiscoveryZNode(),
s.getZookeeperConfigMapName(),
)
return formatZookeeper.Build(formatZookeeper)
}
Expand Down Expand Up @@ -275,6 +275,6 @@ func (s *StatefulSetReconciler) getNameNodeConfigMapSource() *corev1.ConfigMapVo
}

// get zookeeper discovery znode
func (s *StatefulSetReconciler) getZookeeperDiscoveryZNode() string {
func (s *StatefulSetReconciler) getZookeeperConfigMapName() string {
return s.Instance.Spec.ClusterConfigSpec.ZookeeperConfigMapName
}

0 comments on commit 3f77df7

Please sign in to comment.