Fix feedback sync (#55)

lyarenei · Nov 11, 2023 · edc0ef2 · edc0ef2
1 parent 97df66c
commit edc0ef2
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/Jellyfin.Plugin.ListenBrainz.Api/BaseClient.cs b/src/Jellyfin.Plugin.ListenBrainz.Api/BaseClient.cs
@@ -22,7 +22,7 @@ public class BaseClient : HttpClient
     public static readonly JsonSerializerSettings SerializerSettings = new()
     {
         NullValueHandling = NullValueHandling.Ignore,
-        DefaultValueHandling = DefaultValueHandling.Ignore,
+        DefaultValueHandling = DefaultValueHandling.Include,
         ContractResolver = new DefaultContractResolver { NamingStrategy = new SnakeCaseNamingStrategy() }
     };
 

diff --git a/...gin.ListenBrainz.Api.Tests/ListenTests.cs → ...ListenBrainz.Api.Tests/JsonEncodeTests.cs b/...gin.ListenBrainz.Api.Tests/ListenTests.cs → ...ListenBrainz.Api.Tests/JsonEncodeTests.cs
@@ -1,5 +1,7 @@
 using System.Collections.ObjectModel;
 using Jellyfin.Plugin.ListenBrainz.Api.Models;
+using Jellyfin.Plugin.ListenBrainz.Api.Models.Requests;
+using Jellyfin.Plugin.ListenBrainz.Api.Resources;
 using Newtonsoft.Json;
 using Xunit;
 
@@ -40,3 +42,20 @@ public void Listen_EncodeAndDecode()
         Assert.NotNull(deserializedListen);
     }
 }
+
+public class RecordingFeedbackTests
+{
+    [Theory]
+    [InlineData(FeedbackScore.Hated)]
+    [InlineData(FeedbackScore.Loved)]
+    [InlineData(FeedbackScore.Neutral)]
+    public void FeedbackValues_Encode(FeedbackScore score)
+    {
+        var request = new RecordingFeedbackRequest { Score = score };
+        var actualJson = JsonConvert.SerializeObject(request, BaseClient.SerializerSettings);
+        Assert.NotNull(actualJson);
+
+        var expectedJson = @"{""score"":" + (int)score + "}";
+        Assert.Equal(expectedJson, actualJson);
+    }
+}