Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manual installation path in readme #94

Closed
wants to merge 11 commits into from
Closed

Fix manual installation path in readme #94

wants to merge 11 commits into from

Conversation

rigrig
Copy link
Contributor

@rigrig rigrig commented Apr 20, 2024

I tried manually installing listenbrainz_4.0.0.1.zip from #93 (comment) in Jellyfin 10.9, but got this error:

[14:26:57] [ERR] Error creating Jellyfin.Plugin.ListenBrainz.Plugin
Jellyfin.Plugin.ListenBrainz.Exceptions.PluginException: Saving cache failed
 ---> System.IO.DirectoryNotFoundException: Could not find a part of the path '/config/plugins/ListenBrainz_1.0.0.0/cache.json'.
   at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirError)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, UnixFileMode openPermissions, Int64& fileLength, UnixFileMode& filePermissions, Boolean failForSymlink, Boolean& wasSymlink, Func`4 createOpenException)
   at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
   at System.IO.File.Create(String path)
   at Jellyfin.Plugin.ListenBrainz.Managers.ListensCacheManager.Save()
   --- End of inner exception stack trace ---
   at Jellyfin.Plugin.ListenBrainz.Managers.ListensCacheManager.Save()
   at Jellyfin.Plugin.ListenBrainz.Managers.ListensCacheManager.get_Instance()
   at Jellyfin.Plugin.ListenBrainz.PluginImplementation..ctor(ILogger logger, IListenBrainzClient listenBrainzClient, IMusicBrainzClient musicBrainzClient, IUserDataManager userDataManager, IUserManager userManager, ILibraryManager libraryManager)
   at Jellyfin.Plugin.ListenBrainz.PluginService..ctor(ISessionManager sessionManager, ILoggerFactory loggerFactory, IHttpClientFactory clientFactory, IUserDataManager userDataManager, ILibraryManager libraryManager, IUserManager userManager)
   at Jellyfin.Plugin.ListenBrainz.Plugin..ctor(IApplicationPaths paths, IXmlSerializer xmlSerializer, ISessionManager sessionManager, ILoggerFactory loggerFactory, IHttpClientFactory clientFactory, IUserDataManager userDataManager, ILibraryManager libraryManager, IUserManager userManager)
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithManyArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at Microsoft.Extensions.DependencyInjection.ActivatorUtilities.ConstructorMatcher.CreateInstance(IServiceProvider provider)
   at Microsoft.Extensions.DependencyInjection.ActivatorUtilities.CreateInstance(IServiceProvider provider, Type instanceType, Object[] parameters)
   at Emby.Server.Implementations.Plugins.PluginManager.CreatePluginInstance(Type type)

Changing the installation path from plugins/Jellyfin.Plugin.ListenBrainz_1.0.0.0 to plugins/ListenBrainz_1.0.0.0 fixed it, so updating the readme to reflect that.

This PR is against the jellyfin-10.9.x branch because that's what I tested, but it looks like it also applies to main.

@lyarenei
Copy link
Owner

Good catch. Yes, this applies to all local installations, I have it set up for development since forever so I did not really notice. 😅

@lyarenei lyarenei changed the base branch from jellyfin-10.9.x to main April 21, 2024 12:15
@lyarenei
Copy link
Owner

Oh, I see. 🤦

@rigrig Can you please drop all the commits which are for 10.9 support, so I can merge this to main? Thank you. :)

@rigrig
Copy link
Contributor Author

rigrig commented Apr 21, 2024

@lyarenei Sure. Dropping 10.9 commits from a branch called jellyfin-10.9.x felt like a bad idea though, so I made a new PR against main: #95

@rigrig rigrig closed this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants