Enable localization-of-domains optimization by default (chapel-lang#2…

…5517)

[reviewed by @jabraham17]

This enables the localization-of-domains optimization by default, which
was added in chapel-lang#24391. We've been running this in the multi-locale
performance playground for the past month and haven't seen any
degradations due to the change, and are aware of the benefits when it
fires, so are enabling it by default.

This PR simply flips the existing flag and removes the explicit setting
of it in tests that were designed to make sure it was working as
expected.

modules/internal/ChapelArray.chpl

@@ -3057,11 +3057,9 @@ module ChapelArray {
   //
   // These control an optimization in which copying an array from one
   // locale to another will also copy the array's domain if we believe
-  // it's safe to do so.  This optimization is currently off by
-  // default because it was completed close to Chapel 2.1 and we
-  // wanted more time to live with it before having it on by default.
+  // it's safe to do so.  The optimization is currently on by default.
   //
-  config param localizeConstDomains = false,
+  config param localizeConstDomains = true,
                debugLocalizedConstDomains = false;
 
   pragma "init copy fn"

test/arrays/localizeConstDom.compopts

@@ -1 +1 @@
--slocalizeConstDomains=true -sdebugLocalizedConstDomains=true
+-sdebugLocalizedConstDomains=true

test/arrays/sparse/copyRemoteSparse-cs.compopts

@@ -1,2 +1,2 @@
--slocalizeConstDomains=true -sdebugLocalizedConstDomains=true --no-cache-remote -scompressRows=true
--slocalizeConstDomains=true -sdebugLocalizedConstDomains=true --no-cache-remote -scompressRows=false
+-sdebugLocalizedConstDomains=true --no-cache-remote -scompressRows=true
+-sdebugLocalizedConstDomains=true --no-cache-remote -scompressRows=false

test/arrays/sparse/copyRemoteSparse.compopts

@@ -1 +1 @@
--slocalizeConstDomains=true -sdebugLocalizedConstDomains=true --no-cache-remote
+-sdebugLocalizedConstDomains=true --no-cache-remote

test/distributions/block/checkLocalizeConstBlockDom.compopts

@@ -1 +1 @@
--slocalizeConstDomains=true -sdebugLocalizedConstDomains=true
+-sdebugLocalizedConstDomains=true

test/studies/spsMatMatMult/driver.compopts

@@ -1 +1 @@
---no-cache-remote -slocalizeConstDomains=true
+--no-cache-remote