Add the VNDB API as a Game source for visual novels
#165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously entries with any NSFW releases would be filtered. This has been relaxed to allow entries with either one standalone SFW release, zero standalone NSFW releases, or the `In-game Sexual Content Toggle` tag. The `GameModel.image` field is now rudimentarily expunged of sensitive images when the SFW filter is enabled. This is not ideal, but likely requires `GameModel` changes to address properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds VNDB as a new API source for visual novels. The API documentation and endpoint can be found here. All
GameModelfields are populated, and the SFW flag is supported1.Spurred primarily by #164, and Steam typically having a blind spot for visual novels.
Some implementation details for RFC:
GameModel.genresfield is populated withcontenttags that have been scored as significant, and aren't spoilers. This is my interpretation of what most people will actually want, but we can always spit out every tag.2024-10), the plugindateFormatterwill end up coercing these dates to an erroneous specificity (e.g.01-10-2024). This is relatively minor.Footnotes
VN entries with no official SFW releases and no content toggle are filtered out. ↩