Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebased: Added support for basic glob patterns in "inputFile" #317

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

LordJZ
Copy link

@LordJZ LordJZ commented Jul 3, 2017

This is rebase of #199 which fixes #69

Items for improvement:

  • recompile all does not work
  • compilerconfig.json schema validation fails if outputFile is not specified
  • to expand the above, it is somewhat braindead to have compilerconfig.json with [{ "inputFile": "*.scss" }] content, I think it should be assumed? or maybe have an option in compilerconfig.json.defaults?
  • I did not rebase changes in RelativeFilePathFormatProvider.cs since I don't know where that went

cc @304NotModified

@304NotModified
Copy link

compile all does not work

Do you mean "Re-compile all files"?

@LordJZ
Copy link
Author

LordJZ commented Jul 3, 2017

@304NotModified

Do you mean "Re-compile all files"?

Yes, but I've just implemented that.

@LordJZ LordJZ force-pushed the glob-support branch 2 times, most recently from 2b633d9 to ae51e91 Compare July 3, 2017 22:49
@LordJZ LordJZ force-pushed the glob-support branch 2 times, most recently from ae468b1 to a944245 Compare July 4, 2017 00:19
@304NotModified 304NotModified mentioned this pull request Oct 11, 2017
@304NotModified
Copy link

recompile all does not work
compilerconfig.json schema validation fails if outputFile is not specified
to expand the above, it is somewhat braindead to have compilerconfig.json with [{ "inputFile": "*.scss" }] content, I think it should be assumed? or maybe have an option in compilerconfig.json.defaults?
I did not rebase changes in RelativeFilePathFormatProvider.cs since I don't know where that went

@madskristensen are all these required before merging this PR?

@PFight
Copy link

PFight commented Dec 12, 2017

Hey guys, it is great PR, let merge it!!! We are desire it!

@304NotModified
Copy link

304NotModified commented Dec 12, 2017

@madskristensen what needs to be done before this get merged?

#199 (comment) was fixed

@madskristensen
Copy link
Owner

There are conflicts that prevents auto-merge. Also, only 1/4 checkboxes in the was checked. What is the plan for these other ones? Is this PR useful without them checked?

@PFight
Copy link

PFight commented Dec 13, 2017

@madskristensen If IDE will show errors in config JSON, or defaults will miss example for new feature - it is nothing important. Let it be as experimental feature, that only can be enabled if you know how. So you will not break product for all users, and last checkbox is not so critical I think.

By the way, *.csproj very often have simple merge confilcts - git have pure support for merging xml files...

@304NotModified
Copy link

Guess this could be closed? (it's in my mentioned list - https://github.com/pulls/mentioned)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a way to specify global options in a project
4 participants