-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor message sending #514
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
the
A-objc2
Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates
label
Sep 18, 2023
madsmtm
force-pushed
the
msg-send-refactor
branch
5 times, most recently
from
September 20, 2023 12:26
641e394
to
aeb7167
Compare
madsmtm
force-pushed
the
msg-send-refactor
branch
4 times, most recently
from
September 20, 2023 14:10
b76d2c7
to
5816505
Compare
madsmtm
force-pushed
the
msg-send-refactor
branch
8 times, most recently
from
September 20, 2023 20:15
fb5c4ac
to
87048ed
Compare
To hide more implementation details, and to in the future make it possible to always do the fast autorelease optimization, even when working with out parameters.
madsmtm
force-pushed
the
msg-send-refactor
branch
from
September 20, 2023 20:35
87048ed
to
7ea7445
Compare
There is value in having a simpler `MessageReceiver` which is understandable by end users, and that doesn't possibly incur extra costs depending on which arguments/return type you pass it.
madsmtm
force-pushed
the
msg-send-refactor
branch
from
September 20, 2023 20:43
7ea7445
to
0a6df20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-objc2
Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates
bug
Something isn't working
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work outlined in #457.
Motivation: Make the
MessageReceiver
trait more straightforward and understandable for end users, and allow us to more easily change internals ofmsg_send!
.See changelog and individual commits for details.