Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor message sending #514

Merged
merged 17 commits into from
Sep 20, 2023
Merged

Refactor message sending #514

merged 17 commits into from
Sep 20, 2023

Conversation

madsmtm
Copy link
Owner

@madsmtm madsmtm commented Sep 18, 2023

Part of the work outlined in #457.

Motivation: Make the MessageReceiver trait more straightforward and understandable for end users, and allow us to more easily change internals of msg_send!.

See changelog and individual commits for details.

@madsmtm madsmtm added the A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates label Sep 18, 2023
@madsmtm madsmtm force-pushed the msg-send-refactor branch 5 times, most recently from 641e394 to aeb7167 Compare September 20, 2023 12:26
@madsmtm madsmtm force-pushed the msg-send-refactor branch 4 times, most recently from b76d2c7 to 5816505 Compare September 20, 2023 14:10
@madsmtm madsmtm marked this pull request as ready for review September 20, 2023 14:13
@madsmtm madsmtm added bug Something isn't working enhancement New feature or request labels Sep 20, 2023
@madsmtm madsmtm added this to the Usable icrate milestone Sep 20, 2023
@madsmtm madsmtm force-pushed the msg-send-refactor branch 8 times, most recently from fb5c4ac to 87048ed Compare September 20, 2023 20:15
There is value in having a simpler `MessageReceiver` which is understandable by end users, and that doesn't possibly incur extra costs depending on which arguments/return type you pass it.
@madsmtm madsmtm merged commit f0591af into master Sep 20, 2023
19 checks passed
@madsmtm madsmtm deleted the msg-send-refactor branch September 20, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant