Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soften DNSSEC error message for external DNS users #1920

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

stsievert
Copy link

What does this PR implement?
This adds some information about the DNSSEC warning for external/custom DNS users.

I spent some time re-enabling DNSSEC through my registrar because of the strong wording in the warning ("resolve this issue immediately.") See #404 (comment) for more detail.

@JoshData
Copy link
Member

"Custom DNS" is used in this project to refer to user-specified DNS records that the box serves when serving DNS. Please revise the comments to say "when not using this box for DNS (external DNS)".

@stsievert
Copy link
Author

Updated. Should this use output.print_warning instead of output.print_error?

@JoshData
Copy link
Member

JoshData commented Mar 4, 2021

No. Many of the status checks are not applicable when existing external DNS, but they are all errors because the project is designed to be correct when used following the instructions.

@stsievert
Copy link
Author

What else needs to be done before merge? I cleaned up tabs/spaces again.

@JoshData
Copy link
Member

It still says "custom DNS' in the last line.

@stsievert
Copy link
Author

Whoops, fixed. Thanks.

@JoshData
Copy link
Member

JoshData commented May 8, 2021

Apologies, there are conflicts now that need to be resolved.

@stsievert
Copy link
Author

I've fixed the merge conflicts.

I am unsure if 178c587 resolves this issue; if a DS record is set for any domains that do not have DNS hosted by the box, does the error message still appear?

178c587 includes a note that the error message is shown "[i]f a DS record is set for any of your domain names that have DNS hosted on your box."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants