-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Atom feed #59
Open
Lucas-C
wants to merge
1
commit into
mainelabs:master
Choose a base branch
from
Lucas-C:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding Atom feed #59
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
def place_to_html_description(place) | ||
def format_entry(name, value) | ||
i18n_name = I18n.t("simple_form.labels.place.#{name}") | ||
displayed_value = (name == 'kind' ? I18n.t("kinds.codes.#{value}") : value) | ||
"<b>#{i18n_name} :</b> #{displayed_value}" | ||
end | ||
text_entries = place.attributes | ||
.slice('kind', 'street', 'zip_code', 'city', 'description', 'owner_name') | ||
.reject { |k, v| v.nil? } | ||
.map { |name, value| format_entry(name, value) } | ||
twitname = place.twitter_name | ||
twitter_entry = format_entry('twitter_name', "<a href='https://twitter.com/#{twitname}'>@#{twitname}</a>") unless !twitname | ||
url_entry = format_entry('url', "<a href='#{place.url}'>#{place.url}</a>") unless !place.url | ||
logo_img = "<img src='#{place.logo_url}' alt='#{place.name} logo'>" unless !place.logo_url | ||
direct_link = "<a href='/#/place/#{place.id}'>#{I18n.t 'feed.link_to_map_marker'}</a>" | ||
[ | ||
logo_img, | ||
*text_entries, | ||
url_entry, | ||
twitter_entry, | ||
direct_link, | ||
].compact.join '<br>' | ||
end | ||
|
||
atom_feed language: (I18n.locale == :fr ? 'fr-FR' : 'en-US') do |feed| | ||
feed.title I18n.t 'feed.title' | ||
feed.updated @places_items.first.updated_at unless @places_items.empty? | ||
@places_items.each do |place_item| | ||
feed.entry( place_item ) do |entry| | ||
entry.title place_item.name | ||
entry.content place_to_html_description(place_item), type: 'html' | ||
entry.author do |author| | ||
author.name place_item.owner_name | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
spec/features/a_user_can_subscribe_to_the_place_feed_spec.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
require 'rails_helper' | ||
|
||
feature 'A user view the places Atom feed' do | ||
scenario 'there is a link to the map marker in the feed item description' do | ||
create(:place, :active) | ||
|
||
visit '/feed' | ||
|
||
expect(find(:xpath, '//feed/entry[1]/content').text).to include(t('feed.link_to_map_marker')) | ||
end | ||
|
||
scenario 'when several places exist, they have different "updated" times' do | ||
create(:place, :active, updated_at: 3.days.ago) | ||
create(:place, :active) | ||
|
||
visit '/feed' | ||
|
||
expect(find(:xpath, '//feed/entry[1]/updated').text).to_not eq(find(:xpath, '//feed/entry[2]/updated').text) | ||
end | ||
|
||
scenario 'when several places exist, they are ordered chronologically' do | ||
create(:place, :active, name: 'Newest place') | ||
create(:place, :active, name: 'Another place', updated_at: 3.days.ago) | ||
create(:place, :active, name: 'Oldest place', updated_at: 3.months.ago) | ||
|
||
visit '/feed' | ||
|
||
expect(find(:xpath, '//feed/entry[1]/title').text).to eq('Newest place') | ||
expect(find(:xpath, '//feed/entry[2]/title').text).to eq('Another place') | ||
expect(find(:xpath, '//feed/entry[3]/title').text).to eq('Oldest place') | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
name;kind;street;zip_code;city;url;latitude;longitude;twitter_name;logo_url;description;owner_name;owner_email | ||
Craftsmen;company;25 rue Lenepveu;49000;Angers;http://craftsmen.io;47.472041;-0.551269;craftsmenhq;;;; | ||
Craftsmen Angers;company;25 rue Lenepveu;49100;Angers;http://craftsmen.io;47.472041;-0.551269;craftsmenhq;https://pbs.twimg.com/profile_images/425256684244566016/N0wcdLyQ_400x400.jpeg;Webdesign studio;Sébastien Charrier;sebastien@craftsmen.io | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be needed if using factories instead of fixtures.