Apply suggestions from code review

maltee1 · Aug 9, 2024 · 06fcd2d · 06fcd2d
1 parent d75cf03
commit 06fcd2d
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/pkg/signalid/ids.go b/pkg/signalid/ids.go
@@ -40,7 +40,7 @@ func ParseUserID(userID networkid.UserID) (uuid.UUID, error) {
 }
 
 func ParseUserLoginID(userLoginID networkid.UserLoginID) (uuid.UUID, error) {
-	userID, err := ParseUserLoginID(userLoginID)
+	userID, err := uuid.Parse(string(userLoginID))
 	if err != nil {
 		return uuid.Nil, err
 	}
@@ -51,10 +51,6 @@ func ParseUserIDAsServiceID(userID networkid.UserID) (libsignalgo.ServiceID, err
 	return libsignalgo.ServiceIDFromString(string(userID))
 }
 
-func ParseUserLoginIDAsServiceID(userLoginID networkid.UserLoginID) (libsignalgo.ServiceID, error) {
-	return libsignalgo.ServiceIDFromString(string(userLoginID))
-}
-
 func ParsePortalID(portalID networkid.PortalID) (userID libsignalgo.ServiceID, groupID types.GroupIdentifier, err error) {
 	if len(portalID) == 44 {
 		groupID = types.GroupIdentifier(portalID)