Skip to content

Commit

Permalink
Make incorrect condarc only a warning
Browse files Browse the repository at this point in the history
  • Loading branch information
pavelzw committed Dec 14, 2023
1 parent 85a34ff commit f503b2b
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 4 deletions.
11 changes: 11 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,17 @@ jobs:
which micromamba | grep not-on-path/bin
shell: bash -elo pipefail {0}
incorrect-condarc:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ./
with:
condarc-file: test/condarc.yml
- run: |
micromamba search pytorch
shell: bash -elo pipefail {0}
# not properly testable
# https://github.com/actions/runner/issues/2347
# https://github.com/orgs/community/discussions/15452
Expand Down
2 changes: 1 addition & 1 deletion dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/post.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "setup-micromamba",
"version": "1.7.1",
"version": "1.7.2",
"private": true,
"description": "Action to setup micromamba",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion src/options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ const checkForKnownIssues = (options: Options) => {
)
}
if (options.condarcFile && path.basename(options.condarcFile) !== '.condarc') {
throw new Error(
core.warning(
`You are using a condarc file that is not named '.condarc'. This is currently not supported by micromamba, see https://github.com/mamba-org/mamba/issues/1394`
)
}
Expand Down
2 changes: 2 additions & 0 deletions test/condarc.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
channels:
- pytorch

0 comments on commit f503b2b

Please sign in to comment.