Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Call removeEnvironmentFromAutoActivate in post setup #198

Merged
merged 13 commits into from
Feb 21, 2024

Conversation

delsner
Copy link
Contributor

@delsner delsner commented Feb 20, 2024

Motivation

When using setup-micromamba, the micromamba activate <env> line still remains in .bash_profile after the post-processing is run.

Changes

The fix is easy as removeEnvironmentFromAutoActivate(...) is already there, but wasn't called during post-processing.

src/post.ts Outdated Show resolved Hide resolved
@pavelzw
Copy link
Member

pavelzw commented Feb 20, 2024

Also in the all case... Might make sense to move this to a separate function?

@delsner
Copy link
Contributor Author

delsner commented Feb 20, 2024

Also in the all case... Might make sense to move this to a separate function?

yeah, just saw that as well, give me a second.

@pavelzw pavelzw added the bug Something isn't working label Feb 20, 2024
src/post.ts Outdated Show resolved Hide resolved
@pavelzw
Copy link
Member

pavelzw commented Feb 20, 2024

You still need to run pnpm build to actually build your changes

@delsner
Copy link
Contributor Author

delsner commented Feb 20, 2024

You still need to run pnpm build to actually build your changes

The diff does look a bit too large for this change...

@pavelzw
Copy link
Member

pavelzw commented Feb 20, 2024

Could you also add a test here:

grep -F "mamba initialize" ~/.bashrc

@pavelzw
Copy link
Member

pavelzw commented Feb 21, 2024

Can you bump the version number to 1.8.1?

@delsner
Copy link
Contributor Author

delsner commented Feb 21, 2024

feel free to merge @pavelzw

@pavelzw pavelzw merged commit 4225001 into mamba-org:main Feb 21, 2024
63 checks passed
@delsner delsner deleted the fix-deinit-env-activation branch February 21, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants