Skip to content

Commit

Permalink
fix error (nw)
Browse files Browse the repository at this point in the history
  • Loading branch information
mmicko committed Jan 27, 2016
1 parent 8b283b9 commit 9425c14
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/osd/modules/render/d3d/d3dhlsl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1367,7 +1367,7 @@ int shaders::phosphor_pass(render_target *rt, cache_target *ct, int source_index
int next_index = source_index;

// skip phosphor if no influencing settings
if (options->phosphor[0] == 0.0f && options->defocus[1] == 0.0f && options->defocus[2] == 0.0f)

This comment has been minimized.

Copy link
@ImJezze

ImJezze Jan 27, 2016

Contributor

Sorry for that. Strange that it didn't cause an error for me.

This comment has been minimized.

Copy link
@mmicko

mmicko via email Jan 27, 2016

Author Member

This comment has been minimized.

Copy link
@ImJezze

ImJezze Jan 27, 2016

Contributor

Ah ok.

By the way it should be.
if (options->phosphor[0] == 0.0f && options->phosphor[1] == 0.0f && options->phosphor[2] == 0.0f)

Maybe you want to fix it for this release, or I'll make a pull request to fix for the next version.

This comment has been minimized.

Copy link
@mmicko

mmicko via email Jan 27, 2016

Author Member

This comment has been minimized.

Copy link
@ImJezze

ImJezze Jan 27, 2016

Contributor

Okay, I think it's just a minor bug and shouldn't cause any other problem.

if (options->phosphor[0] == 0.0f && options->defocus[0] == 0.0f && options->defocus[1] == 0.0f)
{
return next_index;
}
Expand Down

2 comments on commit 9425c14

@mmicko
Copy link
Member Author

@mmicko mmicko commented on 9425c14 Jan 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 1686fdd

@ImJezze
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please sign in to comment.