Iaejean custom http session #120

iaejean · 2014-09-03T17:37:29Z

Thanks for your advice and apologize for the delay but I also sent the changes and tests, greetings and I am waiting for your comments.

marcelog · 2014-10-02T12:57:49Z

src/mg/Ding/HttpSession/Exception/HttpSessionException.php

+<?php
+namespace Ding\HttpSession\Exception;
+
+class HttpSessionException extends \Exception


Where is this exception thrown? Doesn't seem to be used at all

marcelog · 2014-10-02T13:03:40Z

The pull looks great :) I'll try to make some final tests. If you take care of the comments that I just wrote, we're ready to merge :) Thanks man!

marcelog · 2014-10-02T14:38:31Z

src/mg/Ding/HttpSession/IHttpSession.php

+
+    public function setAttribute($name, $value);
+
+    public function getSession();	


This method is still defined as static in HttpSession... are you sure you ran the tests and they pass?

marcelog · 2014-10-02T14:39:34Z

Tests don't pass for me. Check the comments. And also, for example for the tests in Test_HttpFrontController the session bean is missing.

Please check that all the tests pass, and let me know. I'm still interested in merging :)

Good luck! Cheers,

iaejean and others added 2 commits July 25, 2014 11:20

Feature allow create a custom Session Handler

49840a8

Sesion handler & test

228548d

marcelog reviewed Oct 2, 2014
View reviewed changes

Provide feedback


		public function setAttribute($name, $value);

		public function getSession();