Merge pull request solven-eu#849 from solven-eu/LambdaMethodRef/chain…

…edMethods

methodRef is accepted only if the scope is a name or field

java/src/main/java/eu/solven/cleanthat/engine/java/refactorer/mutators/LambdaIsMethodReference.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2023 Benoit Lacelle - SOLVEN
+ * Copyright 2023-2024 Benoit Lacelle - SOLVEN
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -223,6 +223,13 @@ private boolean onMethodCall(NodeAndSymbolSolver<?> context,
 		}
 		var scope = optScope.get();
 
+		if (!scope.isNameExpr() && !scope.isFieldAccessExpr()) {
+			// https://github.com/solven-eu/cleanthat/issues/847
+			// There is a risk of side-effect if the scope is not the lambda parameter (e.g. if the lambda chains
+			// multiple calls)
+			return false;
+		}
+
 		if (methodCallExpr.getArguments().size() == 1 && methodCallExpr.getArguments().get(0).isNameExpr()
 				&& methodCallExpr.getArguments().get(0).asNameExpr().getName().equals(singleParameter.getName())) {
 

java/src/test/java/eu/solven/cleanthat/engine/java/refactorer/cases/do_not_format_me/TestLambdaIsMethodReferenceCases.java

@@ -7,6 +7,7 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
+import java.util.Optional;
 import java.util.Set;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
@@ -249,6 +250,16 @@ public List<?> pre(Stream<? extends Class<?>> s) {
 		}
 	}
 
+	// https://github.com/solven-eu/cleanthat/issues/847
+	@UnmodifiedMethod
+	public static class CaseRootIsNotLambdaVariable {
+		// Must not be turned into
+		// `o.ifPresent(sb.append("/")::append);`
+		public void pre(Optional<?> o, StringBuilder sb) {
+			o.ifPresent(s -> sb.append("/").append(s));
+		}
+	}
+
 	// https://www.baeldung.com/java-method-references#examples-limitations
 	@UnmodifiedMethod
 	public static class refToExternalVariables {