Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tags-api): custom tags from local variables must be PascalCase #2328

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

LuLaValva
Copy link
Member

Description

When local variables are used as tag names, they must be PascalCase or in a dynamic tag.

import CustomTag from "custom-tag.marko"
import customTag from "custom-tag.marko"

<customTag /> // NOT allowed

<CustomTag /> // allowed
<${CustomTag}/> // allowed
<${customTag}/> // allowed

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: dc708dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/translator-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.75%. Comparing base (3ca55b9) to head (dc708dc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ges/translator-tags/src/visitors/tag/custom-tag.ts 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2328      +/-   ##
==========================================
+ Coverage   88.72%   88.75%   +0.02%     
==========================================
  Files         338      338              
  Lines       35322    35335      +13     
  Branches     2086     2095       +9     
==========================================
+ Hits        31341    31362      +21     
+ Misses       3965     3957       -8     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuLaValva LuLaValva merged commit 13d039f into main Oct 18, 2024
9 checks passed
@LuLaValva LuLaValva deleted the pascal-case-tagnames branch October 18, 2024 22:09
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant