-
-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework docker compose script to allow future extensibility #1002
rework docker compose script to allow future extensibility #1002
Conversation
PR Summary
|
@piotrkwiecinski part of the reason I added Cloudflare to same file is to have it in same network as the rest of app. If you have it separately - I guess we'd manually need to set networks too. But good idea anyways! |
It's going to be my next PR. I want to link services using network, so these changes are easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need a few comments here to explain what the code is doing. Thanks!
Thanks so much, great update! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all set and should be closed out 👍
This is the first step to allow more flexibility.
For example instead of having blackfire commented out in main compose.yaml.
It could be moved to a separate file and included in the list when feature toggle is enabled.
Something like:
It would allow adding features like #998 the same way.