Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved check for empty directory to top of scripts #1143

Merged

Conversation

YevhenZvieriev
Copy link
Contributor

In this pull request, a check has been moved to the top of the scripts to verify the existence of the bin and src directories BEFORE taking any actions. This was done to ensure that the directory is empty BEFORE beginning the process, and prevents unintentional overwriting of content, as well as any errors that might occur during execution.

markshust and others added 3 commits April 25, 2024 12:18
Co-authored-by: Michael Lehmkuhl <michael@electricpulp.com>
Co-authored-by: Jenyamba <is3kv3@ukr.net>
Co-authored-by: Tu Van <vandinhtuit@gmail.com>
Co-authored-by: Cid Lopes <alannettto@gmail.com>
Copy link

what-the-diff bot commented Apr 26, 2024

PR Summary

  • Improvement in Project Control Scripts
    The PR includes updates to the compose/bin/download file. Important scripts have been added to start and stop the Docker project. This allows better control over the project execution.

  • Integration with GitHub Repository
    This PR includes code changes in the lib/template file that allow the docker-magento project to directly integrate with its GitHub repository. This integration allows updates to be easily fetched and implemented from the origin, thereby improving maintainability and ease of use.

  • File Arrangement
    In the lib/template file, some files including compose/*, compose/.gitignore, and compose/.vscode have been moved to the current directory to improve the organization of project files. This is expected to enhance readability and accessibility of the project.

@YevhenZvieriev YevhenZvieriev changed the title Moved empty dir check to the top of the scripts Moved check for empty directory to top of scripts Apr 26, 2024
@markshust
Copy link
Owner

Thanks, this definitely makes sense 👍

@markshust markshust merged commit 5891bf5 into markshust:release/next Apr 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants