Allow to change the default indentation of the produced JSON. #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default is 2, which can lead to fairly large bloat, when considering ten-thousands of JAMS (think global tempo estimates like https://github.com/tempoeval/tempo_eval/tree/main/annotations). Of course one can go the gzip/jamz route, which will create smaller files, but at the price of (easy/casual) editability. Being able to simple pass indent=None is a compromise. It still allows manual editing, while also reducing size quite a bit.
Merged
|
Closed and re-opened PR to trigger Travis build. |
|
Lgtm, @bmcfee any comments before I merge and bump the patch version? |
LGTM, thanks! Before bumping the version, I think it's worth combing through open issues and seeing if there's anything else that needs fixing in the short term. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default is 2, which can lead to fairly large bloat, when considering ten-thousands of JAMS (think global tempo estimates like https://github.com/tempoeval/tempo_eval/tree/main/annotations). Of course one can go the gzip/jamz route, which will create smaller files, but at the price of (easy/casual) editability.
Being able to simple pass indent=None is a compromise. It still allows manual editing, while also reducing size quite a bit.