Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-native-issue-fixes #92

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ddtch
Copy link

@ddtch ddtch commented Nov 23, 2022

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here/ Jira tasks)

  • What is the new behavior (if this is a feature change)?

  • What are the testcases and how have you tested them

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

  • Note:
    Please, go through these steps before you submit a PR.

  1. Make sure that your PR is not a duplicate.

  2. If not, then make sure that:

    a. You have done your changes in a separate branch. Branches MUST have descriptive names that start with either the fix/ or feature/ prefixes. Good examples are: fix/signin-issue or feature/issue-templates.

    b. You have a descriptive commit message with a short title (first line).

    c. You have only one commit (if not, squash them into one commit).

    d. npm test doesn't throw any error. If it does, fix them first and amend your commit (git commit --amend).

  3. After these steps, you're ready to open a pull request.

    a. Give a descriptive title to your PR.

    b. Describe your changes.

    c. Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link
Author

@ddtch ddtch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants