upgrade stripe lib to v8 #68
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratsclub
commented
Jul 17, 2024
Comment on lines
+513
to
514
| # TODO: I actually don't know how to do this on the new api | ||
| event = stripe.Event.construct_from(data, stripe.api_key) |
There was a problem hiding this comment.
This is the only part that is not straightforward to migrate (apart from all the tests). I need to read the docs to see how to do it.
|
@ratsclub looks like stripe-python is up to v10 now: https://github.com/stripe/stripe-python/blob/master/CHANGELOG.md#1030---2024-07-11 Consider upgrading if it's not too much work. I can take a look at the tests! |
|
Seems like we don't need to do anything to bump to v10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.