Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gitbook folder icon #2390

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

okineadev
Copy link
Member

Related to #2387

Copy link
Contributor

github-actions bot commented Jul 6, 2024

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated preview

You can find more information on how to contribute in the contribution guidelines.

Signed-off-by: Philipp Kief <philipp.kief@gmx.de>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better - and that's what was mentioned here #2387 (comment) - is that removing the white background would make more sense. It's then more consistent with the other icons of the theme. In addition the logo on the website provides the icon also without that white background:

image

Maybe we can provide a light and dark icon and only have the book icon with it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already prepared the basis of the icon, but I will not stick it on the folder icon now, because it is already late and every self-respecting Orthodox Christian will rest tomorrow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine! Just let me know if you need support.

@okineadev okineadev marked this pull request as draft July 6, 2024 18:10
@okineadev okineadev changed the title Added gitbook file icon Added gitbook folder icon Jul 6, 2024
@PKief PKief force-pushed the main branch 2 times, most recently from 7918c28 to 7cb05b2 Compare November 13, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants