Merge pull request #4039 from Sharath-1517/fix-favicon_added

Added favicon icons for the page templates in base.html and added respective icons in the static folder
mathesar-foundation · Dec 4, 2024 · 18fe2f3 · 18fe2f3
2 parents 8bcc0d4 + 0baa91d
commit 18fe2f3
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 2 deletions.
diff --git a/mathesar/static/non-code/icons/apple-touch-icon.png b/mathesar/static/non-code/icons/apple-touch-icon.png
diff --git a/mathesar/static/non-code/icons/favicon-16x16.png b/mathesar/static/non-code/icons/favicon-16x16.png
diff --git a/mathesar/static/non-code/icons/favicon-180x180.png b/mathesar/static/non-code/icons/favicon-180x180.png
diff --git a/mathesar/static/non-code/icons/favicon-32x32.png b/mathesar/static/non-code/icons/favicon-32x32.png
diff --git a/mathesar/static/non-code/icons/favicon.ico b/mathesar/static/non-code/icons/favicon.ico
diff --git a/mathesar/templates/mathesar/base.html b/mathesar/templates/mathesar/base.html
@@ -1,12 +1,17 @@
+{% load i18n static %}
 <!DOCTYPE html>
 <html lang="en">
   <head>
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Mathesar - {% block title %}{% endblock %}</title>
 
-    <!-- TODO: Specify Mathesar favicon. Using a dummy data URI until then. -->
-    <link rel="icon" href="data:;base64,iVBORw0KGgo=" />
+    <link rel="icon"  type="image/x-icon"href="{% static 'icons/favicon.ico' %}">
+    <link rel="icon" type="image/png" sizes="16x16" href="{% static 'icons/favicon-16x16.png' %}">
+    <link rel="icon" type="image/png" sizes="32x32" href="{% static 'icons/favicon-32x32.png' %}">
+    <link rel="icon" type="image/png" sizes="180x180" href="{% static 'icons/favicon-180x180.png' %}">
+    <link rel="apple-touch-icon" href="icons/apple-touch-icon.png">
+
 
     <style type="text/css">
       html,