Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell loses focus when clicking on its outline #2987

Open
seancolsen opened this issue Jul 3, 2023 · 15 comments · May be fixed by #4080
Open

Cell loses focus when clicking on its outline #2987

seancolsen opened this issue Jul 3, 2023 · 15 comments · May be fixed by #4080
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@seancolsen
Copy link
Contributor

Steps to reproduce

  1. Prerequisites:

    1. On the table page click on a cell to focus it.
    2. When the cell is focused, you can use the Up and Down arrow keys to move the active cell. This is good.
    3. Click on the "Filter" button above the table to open the filtering dropdown. Click it again to close it. Now that button is focused instead of a cell, and you won't be able to use the arrow keys to move the active cell. This is okay, but important to understand.
  2. Increase your browser zoom to something like 300% to make this easier.

  3. Click on a cell to focus it.

  4. Click on the blue cell border.

  5. Expect the cell to remain focused.

  6. Observe that the cell loses focus.

@seancolsen seancolsen added ready Ready for implementation type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this labels Jul 3, 2023
@seancolsen seancolsen added this to the Backlog milestone Jul 3, 2023
@manthan-jsharma
Copy link
Contributor

@pavish , @rajatvijay , is somebody looking into this issue ?

I'm interested in picking this up

@sahil-adit
Copy link

I am interested to solve this issue,Can you please provide some more information?

@seancolsen
Copy link
Contributor Author

@sahil-adit you're welcome to work on this. Please submit a PR or ask specific questions. If you have questions about this issue, you can ask them here. Or if you have questions about getting set up with Mathesar development, please ask them in Matrix.

@abhirupPann
Copy link

Is this issue still open?

@seancolsen
Copy link
Contributor Author

Yes, @abhirupPann this is still open. You're welcome to submit a PR for it.

@Mahas1234
Copy link

Are there any more fixes needed. I'm looking for first contribution.

@seancolsen
Copy link
Contributor Author

This issue is still open @Mahas1234, feel free to submit a PR.

@smit9924
Copy link

smit9924 commented Aug 20, 2024

Is this issue still open? I would like to fix this up. Please assign to me

@Anish9901
Copy link
Member

Yes, this is still open @smit9924. We are preparing for our beta release currently, so some pieces of the app might be broken in the develop branch. Please feel free to reach out on the issue or on one of our Matrix channels if you need help regarding this issue.

@prakhargupta-jan
Copy link

Is it ok to work on an issue without it being assigned to you I hope I'll not be stepping on anyone's toes. new to Open Source

@smit9924
Copy link

@Anish9901 I debug this issue and would like to have some suggestions:
(1) On click the filter button it is common that cell loses the focus and it might be expected as user click the other element out of the table. I don't feel there isn't anything unexpected over there. According to me we should not lock focus on table cell.
Even thought if we would like to implement that then we can add functionality on filter close to shift focus on particular/first cell of the table
(2) On clicking blue border cell shift focus is actually due to border is lies outside the cell. So on click focus is shift to the another cell. This also can be fixed. But what I have observe is focus on cell not looks that much accurate/attractive so one should go the recreating/improving cell focus overall.

Please make your suggestion on above tow points so I can start working accordingly.
Thank you

@Anish9901
Copy link
Member

Anish9901 commented Aug 26, 2024

@smit9924 Please go ahead with option (2) and open up a PR for it, please note that no design changes are required for this. So, please stick to fixing the behavior you described in option (2).

@sharath-1517
Copy link
Contributor

Hey all, I have tried a possible fix for this issue.

Current behaviour

MOV to GIF

My fix

fix

Before proceeding, I wanted to check: is anyone actively working on this? If not, would it be alright for me to submit a pull request with my proposed changes?

Thanks for your time, and let me know if there's any feedback!

@seancolsen
Copy link
Contributor Author

Please submit a PR @sharath-1517.

@sharath-1517
Copy link
Contributor

Please submit a PR @sharath-1517.

Alright, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
9 participants