Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: possible fix for the cell losing focus when clicking on the border #4080

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

sharath-1517
Copy link
Contributor

@sharath-1517 sharath-1517 commented Dec 16, 2024

Fixes #2987

Technical details

  • Found that the cell was given box-shadow for the [data-active-cell] element.
  • I have changed the box-shadow to outline and set outline-offset in order to make sure that the outline stays inside the cell avoiding overlaps with other cells.

Screenshots

  • Active state of the cell
Screenshot 2024-12-16 at 4 27 45 PM
  • Inactive state of the cell
Screenshot 2024-12-16 at 4 27 47 PM

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I tried running the project locally and verified that there are no
    visible errors.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sharath-1517 sharath-1517 changed the title Possible fix for the cell losing focus when clicking on the border fix: possible fix for the cell losing focus when clicking on the border Dec 16, 2024
@zackkrida zackkrida requested a review from seancolsen December 17, 2024 15:53
@zackkrida zackkrida added the pr-status: review A PR awaiting review label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cell loses focus when clicking on its outline
4 participants