Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TODO_BETA code comments #4076

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

seancolsen
Copy link
Contributor

Fixes #3744

Notes

  • Three TODO_BETA comments were related to public sharing of tables/explorations. I removed those comment blocks entirely because I'm not sure we'll ever re-implement that, and if we do it'll require more than just a few small changes in those code locations.

  • I changed TOOD_BETA to TODO for smaller changes that seem worth doing at some point. If they are changes which should block beta, then I made sure that they are tracked in GitHub issues. For lower-priority changes, I didn't bother to ensure we have GitHub issues to track them. For example get(schema.name) in SchemaSelector.svelte seems okay for now. I tested renaming a schema to see if I could trigger a reactivity bug in the schema selector, and everything seems to function as I'd expect.

  • I'm handling the TODO_BETA comment in pageTitleUtils.ts via Fix small problem with schema name in page titles #4074

  • @pavish I'd like you to fix the TODO_BETA issue in src/systems/data-explorer/utils.ts. I know I asked you about this on a call months ago. I remember you telling me how to fix it. And I remember it making sense at the time. I'm sorry I never actually made a PR for it. Now I've forgotten. And I did try to figure it out again, but this code is pretty tough to work with. I think it would be faster for you to make this change. Can you please push a commit to this PR to deal with it? I can't tell if there's a regression here, which is why I'd like to handle this before beta.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen seancolsen added this to the v0.2.0 (beta release) milestone Dec 13, 2024
@seancolsen seancolsen added the pr-status: review A PR awaiting review label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve all TODO_BETA code comments
2 participants