-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for wide tables #4116
Conversation
…y_json_expr_for_table
…cy on jsonb_build_object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We chatted about this in a call. I think it's ready to merge!
I'll be refactoring the relevant section of code in the near future, so any issues I have can be sorted out at that point.
@@ -4653,63 +4653,63 @@ $$ LANGUAGE SQL STABLE; | |||
CREATE OR REPLACE FUNCTION | |||
msar.build_results_jsonb_array_expr( | |||
cte_name text, | |||
columns text[], | |||
order_by_expr text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realizing now that I missed this in a previous PR review: We should no longer be passing SQL expressions as parameters to functions.
Fixes #4113
Technical details
We were using
jsonb_build_object()
to dynamically build SQL for listing records, listing record summaries and grouping records from a table, this causes issues when the number of arguments forjsonb_build_object()
exceed postgres' default maximum limit which is 100.This PR fixes this issue by using
to_jsonb()
instead.Upon merging of this PR, mathesar will support:
Screenshots
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin