[Backend] Store scraped movie data #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasberggren
changed the title
mathiasberggren
changed the title
mathiasberggren
changed the title
mathiasberggren
changed the title
mathiasberggren
force-pushed
the
basic-database
branch
from
f4bcafe
to
5992df9
Compare
rasouza
reviewed
Apr 15, 2024
rasouza
reviewed
Apr 15, 2024
rasouza
reviewed
Apr 15, 2024
| async create (@Body() createMovieDto: CreateMovieDto) { | ||
| if (createMovieDto.movieTitles.length === 0) { | ||
| throw new BadRequestException('At least one movie title is required') | ||
| } |
There was a problem hiding this comment.
You can delegate the validation responsibility to the DTO instead of the Controller. I left a suggestion up there that you can remove this if here
There was a problem hiding this comment.
Good call! Will remove this
rasouza
reviewed
Apr 15, 2024
Comment on lines
+2
to
+14
| export class CreateMovieDto { | ||
| genre: string | ||
| director: string | ||
| duration: number | ||
| subtitles: string[] | ||
| releaseDate: Date | ||
| movieTitles: CreateMovieTitleDto[] | ||
| } | ||
|
|
||
| export class CreateMovieTitleDto { | ||
| language: string | ||
| title: string | ||
| } |
There was a problem hiding this comment.
Suggested change
| export class CreateMovieDto { | |
| genre: string | |
| director: string | |
| duration: number | |
| subtitles: string[] | |
| releaseDate: Date | |
| movieTitles: CreateMovieTitleDto[] | |
| } | |
| export class CreateMovieTitleDto { | |
| language: string | |
| title: string | |
| } | |
| import { createZodDto } from "nestjs-zod" | |
| import { z } from "nestjs-zod/z" | |
| const CreateMovieSchema = z.object({ | |
| genre: z.string(), | |
| director: z.string(), | |
| duration: z.number().int(), | |
| subtitles: z.string().array().optional(), | |
| releaseDate: z.date(), | |
| movieTitles: z.object({ | |
| language: z.string(), | |
| title: z.string() | |
| }).array().nonempty() | |
| }) | |
| export class CreateMovieDto extends createZodDto(CreateMovieSchema) {} |
There was a problem hiding this comment.
I think this is mainly since I didn't push the pairing session we did :D will do now
There was a problem hiding this comment.
Realized now they come in this branch, would it be OK to merge this branch to master as is and then merge the other one with the DTO changes removing the "if" above?
mathiasberggren
force-pushed
the
basic-database
branch
from
466e24a
to
aa6877b
Compare
…prisma#2377 is resolved through prisma-multischema
Co-authored-by: Rodrigo Souza <alves.wm@gmail.com>
Make sure db tables are in plural and snake_case Co-authored-by: Rodrigo Souza <alves.wm@gmail.com>
…nt movies that are stored in the DB
mathiasberggren
force-pushed
the
basic-database
branch
from
3c3fbee
to
720cd5e
Compare
rasouza
approved these changes
Apr 25, 2024
|
Sorry the delay 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
API
Motivation and Context
How Has This Been Tested?
Running locally and CI
Screenshots (if appropriate):
Types of changes
Checklist: