aliasing the chrome to the different path when it is on Linux OS #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teekenl
changed the title
teekenl
changed the title
| alias chrome='/opt/google/chrome/google-chrome' | ||
| else | ||
| alias chrome='/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome' | ||
| fi |
There was a problem hiding this comment.
Instead of checking uname output and assuming different paths, it seems better to check if the path exists.
There was a problem hiding this comment.
@mathiasbynens 👍, I have updated to check if the file exists instead before aliasing chrome in Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Referencing the issue