Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions with ShellCheck #951

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Commits on Jul 8, 2021

  1. Configuration menu
    Copy the full SHA
    38db21a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    227873f View commit details
    Browse the repository at this point in the history
  3. Fix SC2197

    Fix SC2197: fgrep is non-standard and deprecated. Use grep -F instead.
    
    https://www.shellcheck.net/wiki/SC2197
    asbjornu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    4287fe1 View commit details
    Browse the repository at this point in the history
  4. Fix SC2164

    Fix SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
    
    https://www.shellcheck.net/wiki/SC2164
    asbjornu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    ca8f9e4 View commit details
    Browse the repository at this point in the history
  5. Fix SC2128

    Fix SC2128: Expanding an array without an index only gives the first element.
    
    https://www.shellcheck.net/wiki/SC2128
    asbjornu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    9696540 View commit details
    Browse the repository at this point in the history
  6. Ignore SC1090

    Ignore SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location.
    
    https://www.shellcheck.net/wiki/SC1090
    
    See the following discussion for why SC1090 is disabled and not fixed:
    
    koalaman/shellcheck#507
    asbjornu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    a7c246f View commit details
    Browse the repository at this point in the history
  7. Fix SC2166

    Fix SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
    
    https://www.shellcheck.net/wiki/SC2166
    asbjornu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    2998678 View commit details
    Browse the repository at this point in the history
  8. Fix SC2162

    Fix SC2162: read without -r will mangle backslashes.
    
    https://www.shellcheck.net/wiki/SC2162
    asbjornu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    b9d0c67 View commit details
    Browse the repository at this point in the history
  9. Fix SC2091

    Fix SC2091: Remove surrounding $() to avoid executing output (or use eval if intentional).
    
    https://www.shellcheck.net/wiki/SC2091
    asbjornu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    fa68f55 View commit details
    Browse the repository at this point in the history
  10. Ignore SC2034

    Ignore SC2034: foo appears unused. Verify use (or export if used externally).
    
    https://www.shellcheck.net/wiki/SC2034
    asbjornu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    b0c800f View commit details
    Browse the repository at this point in the history
  11. Ignore SC2154

    Ignore SC2154: yellow is referenced but not assigned.
    
    https://www.shellcheck.net/wiki/SC2154
    asbjornu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    629eab3 View commit details
    Browse the repository at this point in the history
  12. Fix SC2155

    Fix SC2155: Declare and assign separately to avoid masking return values.
    
    https://www.shellcheck.net/wiki/SC2155
    asbjornu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    e18d3b8 View commit details
    Browse the repository at this point in the history
  13. Fix SC1018

    Fix SC1018: This is a unicode non-breaking space. Delete and retype it.
    
    https://www.shellcheck.net/wiki/SC1018
    asbjornu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    7db6203 View commit details
    Browse the repository at this point in the history
  14. Fix SC2124

    Fix SC2124: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.
    
    https://www.shellcheck.net/wiki/SC2124
    asbjornu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    e187a8f View commit details
    Browse the repository at this point in the history
  15. Fix SC2199

    Fix SC2199: Arrays implicitly concatenate in [[ ]]. Use a loop (or explicit * instead of @).
    
    https://www.shellcheck.net/wiki/SC2199
    asbjornu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    6eed23f View commit details
    Browse the repository at this point in the history
  16. Fix SC2181

    Fix SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
    
    https://www.shellcheck.net/wiki/SC2181
    asbjornu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    8926ad3 View commit details
    Browse the repository at this point in the history
  17. Fix SC2046

    Fix SC2046: Quote this to prevent word splitting.
    
    https://www.shellcheck.net/wiki/SC2046
    asbjornu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    3a9318d View commit details
    Browse the repository at this point in the history
  18. Ignore SC2139

    Ignore SC2139: This expands when defined, not when used. Consider escaping.
    
    https://www.shellcheck.net/wiki/SC2139
    asbjornu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    c3d07f2 View commit details
    Browse the repository at this point in the history
  19. Fix SC2140

    Fix SC2140: Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A\"B\"C"?
    
    https://www.shellcheck.net/wiki/SC2140
    asbjornu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    be97206 View commit details
    Browse the repository at this point in the history