-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Actions with ShellCheck #951
Open
asbjornu
wants to merge
19
commits into
mathiasbynens:main
Choose a base branch
from
asbjornu:feature/shellcheck
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jul 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 38db21a - Browse repository at this point
Copy the full SHA 38db21aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 227873f - Browse repository at this point
Copy the full SHA 227873fView commit details -
Fix SC2197: fgrep is non-standard and deprecated. Use grep -F instead. https://www.shellcheck.net/wiki/SC2197
Configuration menu - View commit details
-
Copy full SHA for 4287fe1 - Browse repository at this point
Copy the full SHA 4287fe1View commit details -
Fix SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. https://www.shellcheck.net/wiki/SC2164
Configuration menu - View commit details
-
Copy full SHA for ca8f9e4 - Browse repository at this point
Copy the full SHA ca8f9e4View commit details -
Fix SC2128: Expanding an array without an index only gives the first element. https://www.shellcheck.net/wiki/SC2128
Configuration menu - View commit details
-
Copy full SHA for 9696540 - Browse repository at this point
Copy the full SHA 9696540View commit details -
Ignore SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location. https://www.shellcheck.net/wiki/SC1090 See the following discussion for why SC1090 is disabled and not fixed: koalaman/shellcheck#507
Configuration menu - View commit details
-
Copy full SHA for a7c246f - Browse repository at this point
Copy the full SHA a7c246fView commit details -
Fix SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. https://www.shellcheck.net/wiki/SC2166
Configuration menu - View commit details
-
Copy full SHA for 2998678 - Browse repository at this point
Copy the full SHA 2998678View commit details -
Fix SC2162: read without -r will mangle backslashes. https://www.shellcheck.net/wiki/SC2162
Configuration menu - View commit details
-
Copy full SHA for b9d0c67 - Browse repository at this point
Copy the full SHA b9d0c67View commit details -
Fix SC2091: Remove surrounding $() to avoid executing output (or use eval if intentional). https://www.shellcheck.net/wiki/SC2091
Configuration menu - View commit details
-
Copy full SHA for fa68f55 - Browse repository at this point
Copy the full SHA fa68f55View commit details -
Ignore SC2034: foo appears unused. Verify use (or export if used externally). https://www.shellcheck.net/wiki/SC2034
Configuration menu - View commit details
-
Copy full SHA for b0c800f - Browse repository at this point
Copy the full SHA b0c800fView commit details -
Ignore SC2154: yellow is referenced but not assigned. https://www.shellcheck.net/wiki/SC2154
Configuration menu - View commit details
-
Copy full SHA for 629eab3 - Browse repository at this point
Copy the full SHA 629eab3View commit details -
Fix SC2155: Declare and assign separately to avoid masking return values. https://www.shellcheck.net/wiki/SC2155
Configuration menu - View commit details
-
Copy full SHA for e18d3b8 - Browse repository at this point
Copy the full SHA e18d3b8View commit details -
Fix SC1018: This is a unicode non-breaking space. Delete and retype it. https://www.shellcheck.net/wiki/SC1018
Configuration menu - View commit details
-
Copy full SHA for 7db6203 - Browse repository at this point
Copy the full SHA 7db6203View commit details -
Fix SC2124: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. https://www.shellcheck.net/wiki/SC2124
Configuration menu - View commit details
-
Copy full SHA for e187a8f - Browse repository at this point
Copy the full SHA e187a8fView commit details -
Fix SC2199: Arrays implicitly concatenate in [[ ]]. Use a loop (or explicit * instead of @). https://www.shellcheck.net/wiki/SC2199
Configuration menu - View commit details
-
Copy full SHA for 6eed23f - Browse repository at this point
Copy the full SHA 6eed23fView commit details -
Fix SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. https://www.shellcheck.net/wiki/SC2181
Configuration menu - View commit details
-
Copy full SHA for 8926ad3 - Browse repository at this point
Copy the full SHA 8926ad3View commit details -
Fix SC2046: Quote this to prevent word splitting. https://www.shellcheck.net/wiki/SC2046
Configuration menu - View commit details
-
Copy full SHA for 3a9318d - Browse repository at this point
Copy the full SHA 3a9318dView commit details -
Ignore SC2139: This expands when defined, not when used. Consider escaping. https://www.shellcheck.net/wiki/SC2139
Configuration menu - View commit details
-
Copy full SHA for c3d07f2 - Browse repository at this point
Copy the full SHA c3d07f2View commit details -
Fix SC2140: Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A\"B\"C"? https://www.shellcheck.net/wiki/SC2140
Configuration menu - View commit details
-
Copy full SHA for be97206 - Browse repository at this point
Copy the full SHA be97206View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.