Node.js 20 compatibility #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 6, 2023
|
I'll have a look in the next days. I also had some github actions changes locally. Hope a fix till end of the week works for you :) |
|
Awesome thank you! |
|
PS: If you like just remove my GHA ... it was mainly also for me to proof the "dep increase is enough" solution as working. So also ok for me if you take relevant changes and do not merge. |
|
see #94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is upgrading dependencies and also adds GitHub actions businging. I found out that Node.js 4 and 6 would no longer install so I removed it also frpm the package.json.
Please release a version to make the great library compatible with Node.js 20 too.
because I tried several things maybe better to squash&merge :-)