in-flight buffer credits #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
only testing this for now. Do not care about 8266 |
For discussion: => #165 (comment) |
Repository owner
locked and limited conversation to collaborators
Dec 13, 2024
Repository owner
unlocked this conversation
Dec 14, 2024
…nked responses Referer to #165 Relates to #169 in-flight buffer credits are intended to moderate buffer fill callbacks in AsyncAbstractResponse it could prevent bad designed slow user-callbacks to flood the queue in chunked responces. for response data we need to control the queue and in-flight fragmentation. Sending small chunks could give low latency, but flood asynctcp's queue and fragment socket buffer space for large responses. Let's ignore polled acks and acks in case when we have more in-flight data then the available socket buff space. That way we could balance on having half the buffer in-flight while another half is filling up, while minimizing events in asynctcp q
vortigont
force-pushed
the
buffcredit
branch
from
1b4a929 to
3d3456e
Compare
|
moving to draft until testing is done |
mathieucarbou
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on mathieucarbou/AsyncTCP#33
implement in-flight buffer credits and event moderation for large/chunked responses
in-flight buffer credits are intended to moderate buffer fill callbacks in AsyncAbstractResponse
Refer: #165