move AsyncWebSocket's WS_EVT_CONNECT callback out of AsyncWebSocketClient's constructor #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient's constructor - this is wrong place to call user code from an object constructor - it is wrong to call AsyncWebSocket's method from other's objects constructor - the callback is executed when new object is not yet linked to server's clients list Closes me-no-dev#176
|
We need to add a use case like #176 to test that in SimpleServer. I will do that later and merge. |
|
@vortigont I cannot add commit in your fork. So I will push in a branch in this repo. |
mathieucarbou
added a commit
that referenced
this pull request
Dec 19, 2024
|
replaced by #179 |
oh... I think I need to remove my remote and push to your repo's branches to simplify this next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #176
on the other hand all other events are also triggered similar way, but just not from a constructor. So moving out only one type of event probably also not that perfect. This might require to rethink it all?