Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme on build options #184

Merged
merged 1 commit into from
Dec 22, 2024
Merged

update readme on build options #184

merged 1 commit into from
Dec 22, 2024

Conversation

vortigont
Copy link
Collaborator

No description provided.

mathieucarbou
mathieucarbou previously approved these changes Dec 22, 2024
@mathieucarbou
Copy link
Owner

@vortigont : when we modify the readme, we must also copy all it's content to the index.md file in the doc folder : this part is the source of the website. I didn't do an automatic job yet.
Thanks!

@mathieucarbou
Copy link
Owner

mathieucarbou commented Dec 22, 2024

Also, if you want, why not adding a section called maintainers with 2 bullet points with our GitHub IDs and link to profiles

Also, the library.json ça be updated: you could add your user is to the maintainers : https://github.com/mathieucarbou/ESPAsyncWebServer/blob/main/library.json#L11

Something like


Maintainers

@vortigont
Copy link
Collaborator Author

Hey, @mathieucarbou
thanks! I've updated a bit readme file and copied it to docs/index.md as-is. Hope this should be fine!

@mathieucarbou
Copy link
Owner

Awesome, thanks!

@mathieucarbou mathieucarbou merged commit 88989a7 into main Dec 22, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants