Misc fixes...

matiasdelellis · May 16, 2024 · 2fa9b08 · 2fa9b08
1 parent 9c676bb
commit 2fa9b08
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/lib/Command/SyncAlbumsCommand.php b/lib/Command/SyncAlbumsCommand.php
@@ -124,7 +124,6 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 
 		$users = array();
 		$userId = $input->getOption('user_id');
-		$personNames = array();
 		$person_name = $input->getOption('person_name');
 		$mode = $input->getOption('mode');
 

diff --git a/lib/Helper/Imaginary.php b/lib/Helper/Imaginary.php
@@ -55,7 +55,7 @@ public function getUrl(): ?string {
 		return rtrim($imaginaryUrl, '/');
 	}
 
-	public function hasKey(): ?string {
+	public function hasKey(): bool {
 		$imaginaryKey = $this->config->getSystemValueString('preview_imaginary_key', 'invalid');
 		return ($imaginaryKey !== 'invalid');
 	}

diff --git a/lib/Helper/PhotoAlbums.php b/lib/Helper/PhotoAlbums.php
@@ -244,12 +244,14 @@ private function getMultiPersonsImages(string $userId, int $modelId, array $pers
 			}
 			array_push($multiPersonImages, $images);
 		}
+
+		$noPersons = count($multiPersonImages);
 		$multiPersonMatchingImages = array();
-		for ( $i = 1 ;  $i < count($multiPersonImages) ; ++$i){
-			if ( $i === 1 ){
-				$multiPersonMatchingImages = array_intersect($multiPersonImages[$i-1],$multiPersonImages[$i]);
-			}else{
-				$multiPersonMatchingImages = array_intersect($multiPersonMatchingImages,$multiPersonImages[$i]);
+		for ($i = 1 ;  $i < $noPersons ; ++$i) {
+			if ($i === 1) {
+				$multiPersonMatchingImages = array_intersect($multiPersonImages[$i-1], $multiPersonImages[$i]);
+			} else {
+				$multiPersonMatchingImages = array_intersect($multiPersonMatchingImages, $multiPersonImages[$i]);
 			}
 		}
 		return array_unique($multiPersonMatchingImages);