Split cache config from queue config. #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarHarLinks
reviewed
Feb 26, 2024
AndrewFerr
requested changes
Mar 7, 2024
| cache: | ||
| redisUri: "redis://redis-host:3679" | ||
| ``` | ||
|
|
There was a problem hiding this comment.
docs/advanced/encryption.md needs updating to mention that crypto requires this config to be enabled (instead of queue.monolithic).
Co-authored-by: Andrew Ferrazzutti <andrewf@element.io> Signed-off-by: Will Hunt <will@half-shot.uk>
Signed-off-by: Will Hunt <will@half-shot.uk>
Signed-off-by: Will Hunt <will@half-shot.uk>
AndrewFerr
requested changes
Mar 7, 2024
Co-authored-by: Andrew Ferrazzutti <andrewf@element.io> Signed-off-by: Will Hunt <will@half-shot.uk>
|
Believe everything has been addressed 🥳 |
spantaleev
added a commit
to spantaleev/matrix-docker-ansible-deploy
that referenced
this pull request
Apr 17, 2024
venimus
pushed a commit
to superhero-com/matrix-docker-ansible-deploy
that referenced
this pull request
May 21, 2024
Chasethechicken
pushed a commit
to Chasethechicken/matrix-docker-ansible-deploy
that referenced
this pull request
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason these were conjoined is because we originally wanted a Redis for worker mode, and eventually started using it as a cache. These days we recommend using Redis as a cache, but not for message queueing. This is really confusing, and to be honest could easily be seperated into two configs.
This changes does just that. We're also going to move towards
redisUribecause frankly it allows more options for less work.