Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache rust dependencies in CI at lint stage #916

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Mar 19, 2024

Should hopefully save us a few seconds on rebuilding deps during CI.

EDIT: Currently the cache seems to be going unused.

@Half-Shot Half-Shot marked this pull request as ready for review March 19, 2024 11:26
@Half-Shot Half-Shot requested a review from a team as a code owner March 19, 2024 11:26
timeout-minutes: 30
needs:
- test
- build-homerunner
env:
HOOKSHOT_BUILD_PROFILE: " "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this (and the other instance) intentionally a whitespace to trick the default in build-app.sh? If yes, I'd note this in a comment here (or just assign --debug?)

@tadzik
Copy link
Contributor

tadzik commented Apr 4, 2024

EDIT: Currently the cache seems to be going unused

So does this improve things, or do we hope it will one day?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants