Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spurious "Decryption key withheld" messages #3061

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jan 12, 2023

Fixes element-hq/element-web#23803

Do not store m.room_key.withheld events with a code of m.unavailable in the crypto store: doing so causes a spurious "key withheld" message, and may overwrite more useful messages.

This also includes a change to ensure we update the error message when we receive an m.room_key.withheld - mostly driven by the need to test the change, but seems like an improvement anyway.


Here's what your changelog entry will look like:

🐛 Bug Fixes

... to update the error message
When we receive an `m.unavailable` notification, do not show it as "Decryption
key withheld".
Copy link

@artcodespace artcodespace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@richvdh richvdh merged commit eb058ed into develop Jan 13, 2023
@richvdh richvdh deleted the rav/handle_withheld_unavailable branch January 13, 2023 13:17
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Feb 1, 2023
* Implement decryption via the rust sdk ([\matrix-org#3074](matrix-org#3074)).
* Handle edits which are bundled with an event, per MSC3925 ([\matrix-org#3045](matrix-org#3045)).
* Add null check for our own member event ([\matrix-org#3082](matrix-org#3082)).
* Handle group call getting initialised twice in quick succession ([\matrix-org#3078](matrix-org#3078)). Fixes element-hq/element-call#847.
* Correctly handle limited sync responses by resetting the thread timeline ([\matrix-org#3056](matrix-org#3056)). Fixes element-hq/element-web#23952. Contributed by @justjanne.
* Fix failure to start in firefox private browser ([\matrix-org#3058](matrix-org#3058)). Fixes element-hq/element-web#24216.
* Fix spurious "Decryption key withheld" messages ([\matrix-org#3061](matrix-org#3061)). Fixes element-hq/element-web#23803.
* Fix browser entrypoint ([\matrix-org#3051](matrix-org#3051)). Fixes matrix-org#3013.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element shows "Decryption key withheld" when it wasn't
2 participants