Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Fix inline predictive text and keyboard suggestion toolbar use cases. #890

Merged
merged 62 commits into from
Jul 15, 2024
Merged

Fix inline predictive text and keyboard suggestion toolbar use cases. #890

merged 62 commits into from
Jul 15, 2024

Commits on Nov 24, 2023

  1. Move from reconciliate to committed/uncommitted text.

    @langleyd
    langleyd committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    5239d95 View commit details
    Browse the repository at this point in the history

  2. Push uncommited changes.

    @langleyd
    langleyd committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    817a9b1 View commit details
    Browse the repository at this point in the history

  3. Handle double space to dot conversion as the system does not do this … 

    …for us with shouldChangeTextIn.
    @langleyd
    langleyd committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    0eb0577 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Merge branch 'main' of github.com:matrix-org/matrix-rich-text-editor … 

    …into langleyd/fix_predictive_text_and_suggestions
    @langleyd
    langleyd committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    3517e84 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Merge main and fix crash checkForDoubleSpaceToDotConversion

    @langleyd
    langleyd committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    b447ad1 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Put back reconciliate but don't use it if the diff is just latin char… 

    …acters/whitespace.
    @langleyd
    langleyd committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    56c24e3 View commit details
    Browse the repository at this point in the history

  2. Remove comment

    @langleyd
    langleyd committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    ba64d68 View commit details
    Browse the repository at this point in the history

  3. Fix typos and move withNBSP

    @langleyd
    langleyd committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    2a37312 View commit details
    Browse the repository at this point in the history

  4. Fix plain text mode.

    @langleyd
    langleyd committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    e1e3e94 View commit details
    Browse the repository at this point in the history

  5. Fix selection + tests

    @langleyd
    langleyd committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    a0e22cc View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Merge branch 'main' of github.com:matrix-org/matrix-rich-text-editor … 

    …into langleyd/fix_predictive_text_and_suggestions
    @langleyd
    langleyd committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    fc41527 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. Fix test that falls into the lastReplaceTextUpdate if statement in Wy… 

    …siwygComposerViewModel. This is very unlikely to happen in a real world example.
    @langleyd
    langleyd committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    3b49f18 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Fix clearing of plain text.

    @langleyd
    langleyd committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c418d63 View commit details
    Browse the repository at this point in the history

  2. Fix dictation, by correcting character check for reconciliate. 

    Dictation can add characters like numbers and emojis. We don't want to use reconciliate for this, only for non-latin writing systems. Use the "Common" set
    @langleyd
    langleyd committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d0a6acc View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. added some tests

    @Velin92
    Velin92 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    00e9667 View commit details
    Browse the repository at this point in the history

  2. added a script to force software keyboard

    @Velin92
    Velin92 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    9d538c6 View commit details
    Browse the repository at this point in the history

  3. improve tests

    @Velin92
    Velin92 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    2a15124 View commit details
    Browse the repository at this point in the history

  4. fixed the tests

    @Velin92
    Velin92 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    209c73a View commit details
    Browse the repository at this point in the history

  5. test fix

    @Velin92
    Velin92 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    c524832 View commit details
    Browse the repository at this point in the history

  6. added a test for deleting when text prediction is present

    @Velin92
    Velin92 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    84bb1d0 View commit details
    Browse the repository at this point in the history

  7. improved the tests

    @Velin92
    Velin92 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    865f967 View commit details
    Browse the repository at this point in the history

  8. better docs in tests

    @Velin92
    Velin92 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    7314be8 View commit details
    Browse the repository at this point in the history

  9. improved the test

    @Velin92
    Velin92 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    fda08e0 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Add comment to object replacement character test

    @langleyd
    langleyd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    e637ecb View commit details
    Browse the repository at this point in the history

  2. Add documentation for the replaceText return value

    @langleyd
    langleyd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    eb70a6c View commit details
    Browse the repository at this point in the history

  3. Fix naming of functions, clearer control flow and and re-enable cyclo… 

    …matic_complexity checks
    @langleyd
    langleyd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    f9d1592 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Add logging line and correct replaceText logic

    @langleyd
    langleyd committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    df0275c View commit details
    Browse the repository at this point in the history

  2. Add another failing test for predictive text.

    @langleyd
    langleyd committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c2a4783 View commit details
    Browse the repository at this point in the history

  3. keyboards based testing

    @Velin92
    Velin92 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    deb7c2c View commit details
    Browse the repository at this point in the history

  4. moved the keyboard setup

    @Velin92
    Velin92 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    51b2090 View commit details
    Browse the repository at this point in the history

  5. print the added keyboards

    @Velin92
    Velin92 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b143872 View commit details
    Browse the repository at this point in the history

  6. rework dot conversion and handle case of dot after an inline text pre… 

    …diction.
    @langleyd
    langleyd committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    0c93ce0 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'langleyd/fix_predictive_text_and_suggestions' of github… 

    ….com:matrix-org/matrix-rich-text-editor into langleyd/fix_predictive_text_and_suggestions
    @langleyd
    langleyd committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    49893ef View commit details
    Browse the repository at this point in the history

  8. moved the setup to the earliest possible

    @Velin92
    Velin92 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2f97a0e View commit details
    Browse the repository at this point in the history

  9. Merge branch 'langleyd/fix_predictive_text_and_suggestions' of https:… 

    …//github.com/matrix-org/matrix-wysiwyg into langleyd/fix_predictive_text_and_suggestions
    @Velin92
    Velin92 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    f815b1c View commit details
    Browse the repository at this point in the history

  10. fix

    @Velin92
    Velin92 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    9961ceb View commit details
    Browse the repository at this point in the history

  11. removed the use of the keyboard language change for now

    @Velin92
    Velin92 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c9c9e86 View commit details
    Browse the repository at this point in the history

  12. restored keyboard based tests

    @Velin92
    Velin92 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2f6e24b View commit details
    Browse the repository at this point in the history

  13. adding language during the test itself!

    @Velin92
    Velin92 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    eb264df View commit details
    Browse the repository at this point in the history

  14. sped up the tests a bit

    @Velin92
    Velin92 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    31d32b3 View commit details
    Browse the repository at this point in the history

  15. better docs

    @Velin92
    Velin92 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    9baac8e View commit details
    Browse the repository at this point in the history

  16. Moving the dot back after predictive text was introduced in 17.5

    @langleyd
    langleyd committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    44edc08 View commit details
    Browse the repository at this point in the history

  17. Fix test.

    @langleyd
    langleyd committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ee0795e View commit details
    Browse the repository at this point in the history

  18. Merge branch 'langleyd/fix_predictive_text_and_suggestions' into maur… 

    …oromito/cjk_testing
    @Velin92
    Velin92 authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d5bc8bd View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. better docs and improved the code

    @Velin92
    Velin92 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    13f6cda View commit details
    Browse the repository at this point in the history

  2. Merge branch 'mauroromito/cjk_testing' of https://github.com/matrix-o… 

    …rg/matrix-wysiwyg into mauroromito/cjk_testing
    @Velin92
    Velin92 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    bf53631 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1015 from matrix-org/mauroromito/cjk_testing

    @Velin92
    Velin92 authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    81d7d8f View commit details
    Browse the repository at this point in the history

  4. fix

    @Velin92
    Velin92 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    ad8d163 View commit details
    Browse the repository at this point in the history

  5. fix

    @Velin92
    Velin92 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    1f06539 View commit details
    Browse the repository at this point in the history

  6. fix

    @Velin92
    Velin92 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    c7cd881 View commit details
    Browse the repository at this point in the history

  7. revert

    @Velin92
    Velin92 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    a961188 View commit details
    Browse the repository at this point in the history

  8. added some delay for the CI

    @Velin92
    Velin92 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    10942c6 View commit details
    Browse the repository at this point in the history

  9. fix cyclomatic_complexity check

    @langleyd
    langleyd committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    282f746 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'langleyd/fix_predictive_text_and_suggestions' of github… 

    ….com:matrix-org/matrix-rich-text-editor into langleyd/fix_predictive_text_and_suggestions
    @langleyd
    langleyd committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    dbafe83 View commit details
    Browse the repository at this point in the history

  11. possible fix by delay

    @Velin92
    Velin92 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    9e810c8 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'langleyd/fix_predictive_text_and_suggestions' of https:… 

    …//github.com/matrix-org/matrix-wysiwyg into langleyd/fix_predictive_text_and_suggestions
    @Velin92
    Velin92 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    a499178 View commit details
    Browse the repository at this point in the history

  13. more delay

    @Velin92
    Velin92 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    3fc7e64 View commit details
    Browse the repository at this point in the history

  14. possible fix

    @Velin92
    Velin92 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    8f2a68b View commit details
    Browse the repository at this point in the history

  15. disabled for now

    @Velin92
    Velin92 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    0045c3b View commit details
    Browse the repository at this point in the history

  16. disabled for now

    @Velin92
    Velin92 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    7868e2e View commit details
    Browse the repository at this point in the history

  17. restored

    @Velin92
    Velin92 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f11702e View commit details
    Browse the repository at this point in the history

  18. improved the test code

    @Velin92
    Velin92 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    14f1889 View commit details
    Browse the repository at this point in the history