Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: Rename some straggling 'Identities' to 'Identity' #4072

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

andybalaam
Copy link
Contributor

The main enum was renamed to UserIdentity and some aliases and comments had not kept up.

The main enum was renamed to `UserIdentity` and some aliases and
comments had not kept up.
@andybalaam andybalaam requested review from a team as code owners October 4, 2024 12:50
@andybalaam andybalaam requested review from poljar and richvdh and removed request for a team October 4, 2024 12:50
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.63%. Comparing base (65b4223) to head (4a68f65).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ates/matrix-sdk/src/encryption/identities/users.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4072      +/-   ##
==========================================
- Coverage   84.64%   84.63%   -0.02%     
==========================================
  Files         269      269              
  Lines       28640    28640              
==========================================
- Hits        24243    24240       -3     
- Misses       4397     4400       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andybalaam andybalaam merged commit 5d46b35 into main Oct 4, 2024
40 checks passed
@andybalaam andybalaam deleted the andybalaam/identities-identity branch October 4, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants