Handle gappy state with a single snapshot, attempt 3 #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 3, 2023 15:39
I don't fully remember the details, but may as well pluck this from the previous PR.
kegsay
approved these changes
Nov 6, 2023
sync3/handler/handler.go
Outdated
| h.Dispatcher.OnInvalidateRoom(p.RoomID, joins, invites) | ||
|
|
||
| // 3. Destroy involved users' caches. | ||
| for _, userID := range involvedUsers { |
There was a problem hiding this comment.
involvedUsers is potentially very large (think Matrix HQ). It would be better to cut this down to the connected users first, then continue. Otherwise we will spin a lot of cycles/locks on users not even on the upstream HS...
There was a problem hiding this comment.
It would be better to cut this down to the connected users first, then continue.
Does this run the risk of introducing a race?
added 5 commits
November 7, 2023 13:28
acquire mutex once, rather than N times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A third iteration of "deal with the gappy poll problem".
I pulled out all the independent bits from #329 to other PRs. What was left fell into two categories: a) the original logic for trying to push out live updates with the gappy poll changes; and b) the logic for nuking connections. This PR consists of b) but not a).
Ancestry: #310 -> #329 -> this.
Closes #294.
Closes #232.