Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: ensure metadata about space children doesn't leak to active connections #392

Merged
merged 1 commit into from
Jan 12, 2024

Commits on Jan 12, 2024

  1. bugfix: ensure metadata about space children doesn't leak to active c…

    …onnections
    
    If Alice and Bob are in the same space, and Bob creates a child in that space,
    Alice would incorrectly receive global metadata about that child room if Alice
    was live syncing at that time. This leak did not expose confidential information
    as Alice could receive all that metadata via the /rooms/{roomId}/hierarchy endpoint
    already. However, it would cause clients to put the space child room into the room
    list which would be very confusing, as it would have no timeline and no other data.
    kegsay committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    4c6d504 View commit details
    Browse the repository at this point in the history